Re: NSMatrix, NSCell, NSBrowser,NSBrowserCell proposed patch

[Sergii Stoian]

On 3/22/07, Fred Kiefer <fredkiefer@gmx.de> wrote:
> Sergii Stoian wrote:
> > Forgot to attach files.
> >
>
> Hi Sergii,
>
> I already commit my part of the change. Please give it a try.

Looks good with one strange exception: NSPopUpButton doesn't draw
responder ring although it inherits code from NSCell. Need to solve this.

> I don't thing that your proposed change to setShowsFirstResponder: is
> correct. That way we don't have a chance to store the focus type. It
> will get overridden each time this method is called. This would defy the
> idea that I explained in my previous mail, where you could just set the
> focus type for the browser cells to NSFocusRingTypeNone.

Agree. I've not thought about it. 

> As for the NSMatrix change I am also surprised by the code duplication
> there. But your change looks dangerous. I would expect that for an
> NSMatrix not drawing its background, we run into an infinit loop with
> that change.

Actually _drawCellAtRow:column: and drawCellAtRow:column: complete
duplicates except this dangerous part. I think we can safely remove this 
dangerous code without loosing functionality. I'll   play around this to see if
we could remove this code.

-- 
Sergii Stoian, ProjectCenter maintainer