Re: Gui 0.12.0 regression

[Dirk Meyer]

Fred Kiefer wrote:

> > 4. MPlayer
> >  Compiling file PlayerCtrllr.m ...
> > In file included from PlayerCtrllr.m:17:
> > ../Classes/ScrubbingBar.h:35: error: expected specifier-qualifier-list befor
> e 'NSScrubbingBarStyle'
> > 
> This problem should be completly unrelated to the GNUstep update.

It is not.
NSScrubbingBarStyle is missing.

This patch fixes it:

==> files/patch-ScrubbingBar.h <==
--- Classes/ScrubbingBar.h.orig Tue Feb 22 17:07:54 2005
+++ Classes/ScrubbingBar.h      Tue May  1 19:42:53 2007
@@ -22,7 +22,7 @@
 // info dictionary key
        //      @"SBClickedValue"               NSNumber double
 
-#if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_2
+#if 1
 typedef enum _NSScrubbingBarStyle {
     NSScrubbingBarEmptyStyle = 0,
        NSScrubbingBarProgressStyle = 1,



> > 5. GScheme
> >  Compiling file SchemeTypes.m ...
> > SchemeTypes.m: In function '+[SCMType alloc]':
> > SchemeTypes.m:119: warning: multiple methods named '-setMark:' found
> > /usr/local/GNUstep/System/Library/Headers/AppKit/NSResponder.h:227: warning:
>  using '-(void)setMark:(id)sender'
> > SchemeTypes.h:29: warning: also found '-(id)setMark:(int)newMark'
> > SchemeTypes.m:119: warning: passing argument 1 of 'setMark:' makes pointer f
> rom integer without a cast
> > SchemeTypes.m:119: error: void value not ignored as it ought to be
> > 
> 
> Harmless new warnings, due to added functionality in NSResponder.

Well my compiler sill treat this as error, as he calls the wrong method.
> SchemeTypes.m:119: error: void value not ignored as it ought to be

I patched GScheme so it uses "setMarkScheme" instead of "setMark".

sed -i '' -e 's|setMark:|setMarkScheme:|' SchemeTypes.h SchemeTypes.m


> > 6. ProjectManager
> >  Compiling file Controller.m ...
> > Controller.m: In function '-[Controller dealloc]':
> > Controller.m:79: warning: implicit declaration of function 'NSDebugLLog'
> > Controller.m: In function '-[Controller newProject:]':
> > Controller.m:130: error: 'NSLocalizedDescriptionKey' undeclared (first use i
> n this function)
> > Controller.m:130: error: (Each undeclared identifier is reported only once
> > Controller.m:130: error: for each function it appears in.)
> > 
> 
> Most likely a missing include in the ProjectManager code.

I had to fix 3 files to build it again.
==> files/patch-Controller.m <==
--- Controller.m.orig   Sun Jul  9 16:11:44 2006
+++ Controller.m        Mon Apr 30 10:57:16 2007
@@ -29,6 +29,8 @@
 #import <Foundation/NSFileManager.h>
 #import <Foundation/NSUserDefaults.h>
 #import <Foundation/NSNotification.h>
+#import <Foundation/NSError.h>
+#import <Foundation/NSDebug.h>
 
 #import <AppKit/NSOpenPanel.h>
 #import <AppKit/NSView.h>

==> files/patch-ProjectCreator.m <==
--- ProjectCreator.m.orig       Sun Jul  9 16:11:43 2006
+++ ProjectCreator.m    Mon Apr 30 10:53:41 2007
@@ -27,6 +27,7 @@
 #import <Foundation/NSUserDefaults.h>
 #import <Foundation/NSNotification.h>
 #import <Foundation/NSError.h>
+#import <Foundation/NSProcessInfo.h>
 
 #import <AppKit/NSOpenPanel.h>
 #import <AppKit/NSView.h>

==> files/patch-ProjectDocument.m <==
--- ProjectDocument.m.orig      Sun Jul  9 16:11:43 2006
+++ ProjectDocument.m   Mon Apr 30 10:54:26 2007
@@ -28,6 +28,7 @@
 #import <Foundation/NSDictionary.h>
 #import <Foundation/NSUserDefaults.h>
 #import <Foundation/NSProcessInfo.h>
+#import <Foundation/NSError.h>
 
 #import <AppKit/NSWorkspace.h>
 #import <AppKit/NSDocumentController.h>


kind regards Dirk

- Dirk Meyer, Im Grund 4, 34317 Habichtswald, Germany
- [dirk.meyer@dinoex.sub.org],[dirk.meyer@guug.de],[dinoex@FreeBSD.org]
http://people.freebsd.org/~dinoex/errorlogs/
- Tel. +49-5606-6512
- Tel. +49-6430-925273
- Tel. +49-177-8911245
- Fax  +49-5606-55023