Re: Please test new NSLock implementation!

[Philippe Roussel]

Le mercredi 02 septembre 2009 à 16:39 +0100, David Chisnall a écrit :
> On 2 Sep 2009, at 16:40, Philippe Roussel wrote:
> 
> > Hi David
> >
> > It no longer locks but emits 2 FAILs
> >
> > FAIL: Recursive lock with NSLock raises an exception
> > FAIL: Recursive lock with NSConditionLock raises an exception
> >
> > Is that what you expexted ?
> 
> Yup, these are now expected fails (I haven't updated the tests).  OS X  
> doesn't throw this exception either, but it deadlocks (which was the  
> behaviour you were seeing before, but OS X also logs a warning, which  
> you weren't seeing).

A detail : you might want to change the NSException format string used
in -(void)lock methods. It now reads "failed to _unlock_ mutex".

Philippe