Re: Problem with GSFromUnicode in Unicode.m

[Richard Frith-Macdonald]

On 2 Mar 2011, at 14:33, Sebastian Reitenbach wrote:

> Hi,
> 
> When i want to install sieve scripts from ogo into the cyrus imapd sieve 
> daemon, ogo uses the tool sky_install_sieve. This tool crashes, converting a 
> unicode string (actually the filter list), due to a double free?
> 
> As far as I can see, the problem might be in GSFromUnicode in Unicode.m, see 
> the backtrace below.
> Attached patch fixes the problem for me, but I am not sure whether this is 
> actually right. I also don't have a mac to see whether/how it is working 
> there. The only thing I can tell is that with libFoundation, it was working, 
> and I guess it was also tested and working on the mac, years ago.
> 
> This happens for me with gnustep-base-1.20.2. also the patch is against it.
> I additionally check for zone != 0, since I don't think it makes sense to 
> free 
> a zone which is already 0, which is was here for me all the time.
> The patch also still applies to -trunk, with offset of -3 lines.

Thanks ... I looked at that code and I think the problem was a logic error 
(test of the dst pointer the wrong way round).
I made small changes in svn trunk ... please give it a try.