GSUseFreedesktopThumbnails is not working correctly

[Andreas Schik]

Hi all,
I just detected that GSUseFreedesktopThumbnails is not working
correctly. If this option is turned on, GWorkspace won't display images
for files that do not have a thumbnail (in $HOME/.thumbnails). For files
having thumbnails, the icon is displayed correctly.

The cause lies in NSWorkspace's method - (NSImage*) iconForFile:

Here, you find the following code:

      if ([[NSUserDefaults standardUserDefaults] boolForKey:
              @"GSUseFreedesktopThumbnails"])
        {
          /* This image will be 128x128 pixels as oposed to the 48x48
             of other GNUstep icons or the 32x32 of the specification */
          image = [self _saveImageFor: [self thumbnailForFile: fullPath]];
          if (image != nil)
            {
              return image;
            }
        }

Unfortunately, image is never nil. If no thumbnail file exists, an
NSImage object is returned which contains no representations (check
class NSBitmapImageRep, +imageRepsWithData:). Hence, no image is
displayed, not even the one for unknown file types.

Regards,
Andreas

signature.asc
Description: OpenPGP digital signature