Re: printing, default printer

[Eric Wasylishen]

Hi Fred,
Ah, thanks for finding that. I tried moving _finalWritePrintInfo: to the end of 
_pickedButton: and that fixed the "save" and "preview" buttons, so I committed 
that change. 

Eric

On 2011-12-15, at 1:40 AM, Fred Kiefer wrote:

> The main printing change I could find for the last few months was some 
> cleanup I did in June 
> (http://svn.gna.org/viewcvs/gnustep?view=revision&revision=33252) when 
> switching to newer methods for the print panel.
> I don't have any idea how this could be causing the issue, but will look into 
> it on the weekend, when I hopefully have a bit more time for GNUstep.
> OK, I could not resist and had a short look. The problem is that
> _finalWritePrintInfo: gets called too soon in _pickedButton:. When we call 
> this method the _picked ivar isn't set nor is the _savePath. Maybe ti would 
> be sufficient to move this call down just before the stopping of the modal 
> loop? I will test that on the weekend...
> 
> Fred
> 
> On 15.12.2011 08:24, Eric Wasylishen wrote:
>> I committed some fixes to printing, and rewrote -[NSTextView
>> adjustPageHeightNew:top:bottom:limit:]. It should be a bit more
>> robust now.
>> 
>> The "Save" and "Preview" buttons still don't work, but they do
>> generate PostScript in /tmp/GNUstepSecure1000. (even if you use the
>> save dialog to save to a PDF file, which used to work a few months
>> ago, it doesn't do anything except write PostScript to /tmp). Same
>> result with CUPS and with GSLPR.
>> 
>> I don't understand how the save/preview buttons are supposed to work.
>> Are they supposed to create a GSPDFPrintOperation or
>> GSEPSPrintOperation object, or use the current
>> GSLPR/GSCUPSPrintOperation?
> 
> _______________________________________________
> Discuss-gnustep mailing list
> Discuss-gnustep@gnu.org
> https://lists.gnu.org/mailman/listinfo/discuss-gnustep