Re: Fractional values for the content view of a Tab

[Gregory Casamento]

This issue will exist in .gorm files created prior to this change.   In NSTabViewItem the frame of the view for the item will be persisted when encodeWithCoder: archives the object.

What I don't fully understand is why, in NSTabView, when -selectTabViewItem: is called and the contentView is calculated and set on the view of the NSTabViewItem why that seems to have no effect.

Nevertheless I believe the above change is part of the solution.

GC

On Thu, Feb 21, 2013 at 8:00 PM, Riccardo Mottola <riccardo.mottola@libero.it> wrote:

Hi,

I propose the patch below (in the quest of why MDIndexer has a blurry UI). It solves the visualization inside Gorm, which now looks correct, but it still doesn't fix the visualization inside SystemPreferences.

What do you think?

Riccardo

Index: Source/NSTabView.m
===================================================================
--- Source/NSTabView.m  (revision 36181)
+++ Source/NSTabView.m  (working copy)
@@ -390,7 +390,7 @@
   switch (_type)
     {
       case NSTopTabsBezelBorder:
-        return NSMakeSize(2, 19.5);
+        return NSMakeSize(2, 19);
       case NSNoTabsBezelBorder:
         return NSMakeSize(2, 3);
       case NSNoTabsLineBorder:
@@ -421,19 +421,19 @@
     {
       case NSTopTabsBezelBorder:
         cRect.origin.y += 1;
-        cRect.origin.x += 0.5;
+        cRect.origin.x += 1;
         cRect.size.width -= 2;
-        cRect.size.height -= 18.5;
+        cRect.size.height -= 19;
         break;
       case NSNoTabsBezelBorder:
         cRect.origin.y += 1;
-        cRect.origin.x += 0.5;
+        cRect.origin.x += 1;
         cRect.size.width -= 2;
         cRect.size.height -= 2;
         break;
       case NSNoTabsLineBorder:
         cRect.origin.y += 1;
-        cRect.origin.x += 0.5;
+        cRect.origin.x += 1;
         cRect.size.width -= 2;
         cRect.size.height -= 2;
         break;

_______________________________________________
Discuss-gnustep mailing list
Discuss-gnustep@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnustep

--
Gregory Casamento
Open Logic Corporation, Principal Consultant
yahoo/skype: greg_casamento, aol: gjcasa
(240)274-9630 (Cell)
http://www.gnustep.org
http://heronsperch.blogspot.com