[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gnustep-config macro should be guarded against output of Make
From: |
Richard Frith-Macdonald |
Subject: |
Re: gnustep-config macro should be guarded against output of Make |
Date: |
Thu, 16 Jan 2014 15:41:43 +0000 |
On 16 Jan 2014, at 15:05, Mathias Bauer <mathias_bauer@gmx.net> wrote:
> Hi,
>
> if a Makefile containing a call to gnustep-config is called with "-C" option,
> it prints out messages for entering/leaving a directory. This gets forwarded
> to the Make call inside of gnustep-config and this spoils its output (and of
> course breaks the build).
>
> This should be fixed by adding "--no-print-directory" to the Make calls in
> gnustep-config.in, e.g.
>
>> --objc-flags) @GNUMAKE@ --no-print-directory -s -f
>> "$GNUSTEP_MAKEFILES/empty.make" print-gnustep-make-objc-flags quiet=yes
>> 2>/dev/null
>
> and some more places in that file.
>
> Would that be acceptable?
That sounds fine ... do you want to make a patch, or shall I?