You probably did not mean to check for the OS in a switch-case, then have the same code in the "darwin*)" branch and in the default "*)" branch. Just remove the case statement and leave AC_DEFINE() by itself.
Did you really mean to pollute the global namespace with 'void SetThreadName()'? You should probably use the 'static' qualifier here.
When calling PTHREAD_SETNAME(), you use a tab instead of two spaces for indentation. Same for the SetThreadName() body and the struct tagTHREADNAME_INFO body. (And it seems that the same applies to
configure.ac.) Please use two spaces for indentation.
...we really need a proper code review system :-)
Hi
Thanks for the pointers, Richard. I have a made some changes that seem to work well on FreeBSD.
I tried to cover Linux, Mac OS X and Windows as well but those require testing.
I'm quite new with autoconf and I don't know if this is the way to do it so I would appreciate some feedback if someone want to take a look at my patch (attached in this mail).
Best regards
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
秘密保持について:この電子メールは、名宛人に送信したものであり、秘匿特権の対象となる情報を含んでいます。
もし、名宛人以外の方が受信された場合、このメールの破棄、およびこのメールに関する一切の開示、
複写、配布、その他の利用、または記載内容に基づくいかなる行動もされないようお願い申し上げます。
---
CONFIDENTIALITY NOTE: The information in this email is confidential
and intended solely for the addressee.
Disclosure, copying, distribution or any other action of use of this
email by person other than intended recipient, is prohibited.
If you are not the intended recipient and have received this email in
error, please destroy the original message._______________________________________________
Discuss-gnustep mailing list
Discuss-gnustep@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnustep