Re: HiDPI in Terminal.app

[Fred Kiefer]

Thank you for your patch. I am sure it works but it does not address the 
underlying issue. The real problem is that DPSshow ignores the current 
transformation of the window and sets a mirrored identity matrix as the 
transformation. This works well in some cases but is clearly wrong. We should 
move ll application code away from this out dated interface. And I will have to 
find a way to fix the behaviour, while keeping at least some of the differences 
that DPSshow has to the regular text display code, e.g. not respecting any 
rotations.

Fred



> Am 17.07.2017 um 21:25 schrieb Steven R. Baker <steven@stevenrbaker.com>:
> 
> Heya,
> 
> I've been hacking on Terminal.app a bit, to try and get it working in HiDPI.  
> The problem is that the cell size seems to be set correctly according to the 
> scale, but when the characters are rendered they are *not* scaled.  You wind 
> up with a large character cell, with a character in the bottom left corner of 
> it, and gaps everywhere.
> 
> I think I have it working, but the solution doesn't feel right. You can see 
> it here: 
> https://github.com/srbaker/gap/commit/8fe99150704a10d6b3b6b70947361376dcc3c819
>  If this *is* appropriate, I'll generate a patch and sign the copyright 
> assignment stuff, etc.
> 
> Some explanation, so you can follow along my thinking.  In TerminalView.m, 
> the characterCellSize class method sets the size of a character cell 
> correctly.  I suspect that this because boundingRectForFont knows the scale 
> factor, but the DPSshow() call (around line 728 in my edited file, inside 
> drawRect:) does *not* know what the scale factor is because it doesn't know 
> the scale factor.
> 
> I feel like the correct thing to do here is to handle scaling in DPS, but at 
> this point I'm quite over my head.  Thoughts, please. I'm willing to do the 
> work, but I just feel like I'm barking up the wrong tree here...
> 
> Cheers!
> 
> -Steven
> 
> 
> 
> _______________________________________________
> Discuss-gnustep mailing list
> Discuss-gnustep@gnu.org
> https://lists.gnu.org/mailman/listinfo/discuss-gnustep