Re: ICU / UDAT_PATTERN issue in NSDateFormatter

[Stefan Bidigaray]

Hi Ricardo, I pushed the change to this code just a few weeks ago. We are using UDAT_PATTERN now, this was not the case before.

UDAT_PATTERN was introduced in ICU version 50, though. Can our mingw install be upgraded to this version of ICU? This new code was introduced to fix a bug in some versions of ICU. The 4.6 version is pretty old, so it would be worth updating it. I would prefer to not have to add #ifdef around this stuff, if possible.

Stef

On Nov 4, 2017 11:07, "Riccardo Mottola" <riccardo.mottola@libero.it> wrote:

Hi,

when building current base on MinGW using our currently supplied MSYS environment, I get this compile issue:

 Compiling file NSDate.m ...
 Compiling file NSDateFormatter.m ...
NSDateFormatter.m: In function '-[NSDateFormatter(PrivateMethods) _resetUDateFormat]':
NSDateFormatter.m:949:21: error: 'UDAT_PATTERN' undeclared (first use in this function)
NSDateFormatter.m:949:21: note: each undeclared identifier is reported only once for each function it appears in
make[4]: *** [obj/libgnustep-base.obj/NSDateFormatter.m.o] Error 1
make[4]: *** Waiting for unfinished jobs....


ICU is installed, I think it is 4.6. I wonder what is going wrong? this doesn't look like a recent change.

I am trying to see what can be upgraded in our windows packages, but it is proving where difficult and brittle!

Adam, can you build current base on your setup?


Riccardo


_______________________________________________
Discuss-gnustep mailing list
Discuss-gnustep@gnu.org
https://lists.gnu.org/mailman/listinfo/discuss-gnustep