Re: Linux/Clang/Libobjc2 failure part 2 (ng)

[Riccardo Mottola]

Hi,

On 2018-06-25 11:16:44 +0200 David Chisnall <gnustep@theravensnest.org> wrote:

> On 24 Jun 2018, at 21:28, Riccardo Mottola <riccardo.mottola@libero.it> wrote:
> 
>> The patch doesn't apply clean anymore, the code looks changed enough!
> 
>> there is no objc_test_class_flag(class, objc_class_flag_new_abi) anymore? 
>> Where should I call objc_test_class_flag(class, objc_class_flag_new_abi)) 
>> now? please check and perhaps update the patch to your changes, so I can 
>> test it.
> 
> Ah, sorry.  The newer structure of the runtime upgrades all class structures 
> to the modern one in a single place.  If you call 
> objc_legacy_class_for_class() and it doesn’t return anything, then it’s a 
> GNUstep ABIv2 class, but you shouldn’t need to do that - you can just 
> unconditionally set the offset variable that dlsym finds to the correct 
> offset, if it finds a symbol.


sorry.. I tried that at the end of the loop, insrting the same code the patch 
had.
But apparently ivars_offset[] is not found in objc_class struct.

I want to be sure to test the correct thing. If you can make me the patch 
clean, I can test it.

Thank you,

Riccardo