|
From: | David Chisnall |
Subject: | Re: libobjc2 still failing tests |
Date: | Fri, 25 Jan 2019 16:41:35 +0000 |
User-agent: | Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 25/01/2019 14:01, Andreas Fink wrote:
I found out what makes it break. The cmake option -DCMAKE_BUILD_TYPE=RelWithDebInfo
Thanks. There was a bug in the log2 calculation for storing the ivar offsets that worked at O0 because of wrapping behaviour when we truncated the value to 32-bit, but triggered undefined behaviour that allowed the optimiser to remove a check. The tests are now all passing for me in release and debug configurations.
David
[Prev in Thread] | Current Thread | [Next in Thread] |