discuss-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GUI incompatibility


From: Andreas Höschler
Subject: Re: GUI incompatibility
Date: Thu, 14 May 2020 00:53:29 +0200

Hi Fred,

>> I could fix the problem under GNUstep by simply commenting out
>> 
>> 
>> /*              if (_firstResponder != v && ![v isKindOfClass: [NSButton 
>> class]])
>>                {
>>                  // Only try to set first responder, when the view wants it.
>>                  if ([v acceptsFirstResponder] && ![self makeFirstResponder: 
>> v])
>>                    {
>>                      return;
>>                    }
>>                }
>> */
>> 
>> Does anything speak against submitting this change into the public tree?
> 
> Just commenting out parts of the code won’t do. As you could probably see 
> with your own code by adding a log statement in acceptsFirstResponder that 
> method needs to be called. Other changes to this logic here are welcome, but 
> they need to address more than one specific issue. Maybe you could provide 
> more details on what happens on Cocoa?

On Cocoa this happens.

> 13/05/20 17:23:40,783 InterfaceBuilder[93679]: <FormTextField: 0x102cd30> 
> acceptsFirstMouse 1
> 13/05/20 17:23:40,783 InterfaceBuilder[93679]: <FormTextField: 0x102cd30> 
> becomeFirstResponder 0
> 13/05/20 17:23:40,784 InterfaceBuilder[93679]: <FormTextField: 0x102cd30> 
> mouseDown ..

So we might want to call acceptsFirstResponder: but not drop out if the answer 
is NO but call mouseDown: anyway!? This would probably mimic the Cocoa 
behaviour!

Regards,

 Andreas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]