discuss-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

NSSwitch drawRect bug


From: Austin Clow
Subject: NSSwitch drawRect bug
Date: Fri, 11 Aug 2023 14:23:20 -0500

In NSSwitch.m, the method for drawRect is as follows: 

- (void) drawRect: (NSRect)rect
{
  [[GSTheme theme] drawSwitchInRect: rect
                           forState: _state
                            enabled: [self isEnabled]];
}

I believe it should be 

- (void) drawRect: (NSRect)rect
{
  [[GSTheme theme] drawSwitchInRect: [self bounds]
                           forState: _state
                            enabled: [self isEnabled]];
}

As it is right now, when it redrawing a rect, it will redraw it within rect causing it to draw bigger and smaller depending not he redraw area. I'm not comfortable yet doing pull requests for a library I am largely unfamiliar with. 

I know the drawing method is kinda ugly right now. I am thinking about rewriting it. 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]