dmidecode-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[dmidecode] [PATCH] dmidecode: Decode processor ID of Core M, Athlon X4,


From: Jean Delvare
Subject: [dmidecode] [PATCH] dmidecode: Decode processor ID of Core M, Athlon X4, Opteron X1000/X2000
Date: Wed, 5 Apr 2017 15:01:02 +0200

When these processors were added from SMBIOS specification version
3.0.0, I forgot to update dmi_processor_id accordingly. Do it now and
add a comment so that it does not happen again.

Fixes: a0edbb45b2e6 ("dmidecode: Add enums from the SMBIOS 3.0.0 specification")
---
 dmidecode.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

--- dmidecode.orig/dmidecode.c  2017-04-04 09:51:13.251502656 +0200
+++ dmidecode/dmidecode.c       2017-04-04 09:57:19.281831668 +0200
@@ -894,6 +894,10 @@ static const char *dmi_processor_family(
                { 0x15E, "DSP" },
                { 0x1F4, "Video Processor" },
        };
+       /*
+        * Note to developers: when adding entries to this list, check if
+        * function dmi_processor_id below needs updating too.
+        */
 
        /* Special case for ambiguous value 0x30 (SMBIOS 2.0 only) */
        if (ver == 0x0200 && data[0x06] == 0x30 && h->length >= 0x08)
@@ -1030,7 +1034,7 @@ static void dmi_processor_id(u8 type, co
                }
        }
        else if ((type >= 0x0B && type <= 0x15) /* Intel, Cyrix */
-             || (type >= 0x28 && type <= 0x2B) /* Intel */
+             || (type >= 0x28 && type <= 0x2C) /* Intel */
              || (type >= 0xA1 && type <= 0xB3) /* Intel */
              || type == 0xB5 /* Intel */
              || (type >= 0xB9 && type <= 0xC7) /* Intel */
@@ -1042,6 +1046,7 @@ static void dmi_processor_id(u8 type, co
              || type == 0x1F /* AMD */
              || (type >= 0x38 && type <= 0x3F) /* AMD */
              || (type >= 0x46 && type <= 0x4F) /* AMD */
+             || (type >= 0x66 && type <= 0x68) /* AMD */
              || (type >= 0x83 && type <= 0x8F) /* AMD */
              || (type >= 0xB6 && type <= 0xB7) /* AMD */
              || (type >= 0xE4 && type <= 0xEF)) /* AMD */


-- 
Jean Delvare
SUSE L3 Support



reply via email to

[Prev in Thread] Current Thread [Next in Thread]