[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [dmidecode] [PATCH v3 3/4] dmioem: Decode HPE OEM Record 203
From: |
Jean Delvare |
Subject: |
Re: [dmidecode] [PATCH v3 3/4] dmioem: Decode HPE OEM Record 203 |
Date: |
Fri, 15 Jan 2021 11:16:00 +0100 |
On Wed, 13 Jan 2021 10:48:25 -0700, Jerry Hoemann wrote:
> HP Device Correlation Record (Type 203)
>
> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
> ---
> dmioem.c | 172 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 172 insertions(+)
>
> diff --git a/dmioem.c b/dmioem.c
> index d77d7b2..3f819ce 100644
> --- a/dmioem.c
> +++ b/dmioem.c
> (...)
> +static void dmi_hp_203_bayenc(const char *fname, u8 num)
> +{
> + switch (num) {
> + case 0x00:
> + pr_attr(fname, "Unknown");
> + break;
> + case 0xff:
> + pr_attr(fname, "Do Not Display");
> + break;
> + default:
> + pr_attr(fname, "0x%d", num);
0x%d is going to be veeery confusing ^^ I guess you forgot to remove
the leading 0x when changing the format. I'll fix it before committing.
Everything else looks good now, thanks.
--
Jean Delvare
SUSE L3 Support
- [dmidecode] [PATCH v3 0/4] dmidecode: Decode HPE OEM Records 203 and 240., Jerry Hoemann, 2021/01/13
- [dmidecode] [PATCH v3 1/4] dmidecode: Make dmi_print_memory_size global., Jerry Hoemann, 2021/01/13
- [dmidecode] [PATCH v3 3/4] dmioem: Decode HPE OEM Record 203, Jerry Hoemann, 2021/01/13
- Re: [dmidecode] [PATCH v3 3/4] dmioem: Decode HPE OEM Record 203,
Jean Delvare <=
- [dmidecode] [PATCH v3 2/4] dmioem: Decode HPE OEM Record 240, Jerry Hoemann, 2021/01/13
- [dmidecode] [PATCH v3 4/4] dmioem: Fix HPE OEM 236, Jerry Hoemann, 2021/01/13
- Re: [dmidecode] [PATCH v3 0/4] dmidecode: Decode HPE OEM Records 203 and 240., Jean Delvare, 2021/01/15