dmidecode-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [dmidecode] [PATCH] dmioem: Present HPE type 240 attributes in a nic


From: Jean Delvare
Subject: Re: [dmidecode] [PATCH] dmioem: Present HPE type 240 attributes in a nicer way
Date: Tue, 19 Jan 2021 16:25:39 +0100

On Fri, 15 Jan 2021 14:39:16 -0700, Jerry Hoemann wrote:
> On Fri, Jan 15, 2021 at 05:46:07PM +0100, Jean Delvare wrote:
> > Present HPE type 240 attributes as a proper list instead of
> > packing them on a single line. This makes it more readable overall,
> > and will also scale better if the number of attributes increases.  
> 
> 
> Output looks good.  I don't see any errors.  One minor suggestion inline.
> 
> > 
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > ---
> > Hi Jerry,
> > 
> > This is my alternative proposal to display the HPE type 240 attributes.
> > Before:
> > 
> >     Attributes Def: Updatable ResetRequired AuthenticationRequired InUse 
> >     Attributes Set: Updatable ResetRequired InUse 
> > 
> > After:
> > 
> >     Attributes:  
> 
> 
> Would we want something like?    Attributes Defined/Set:

OK, I changed it to that.

-- 
Jean Delvare
SUSE L3 Support



reply via email to

[Prev in Thread] Current Thread [Next in Thread]