|From:||Laurent Destailleur (eldy)|
|Subject:||Re: [Dolibarr-dev] PHP Standards|
|Date:||Wed, 13 Jun 2012 14:20:38 +0200|
|User-agent:||Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1|
No. Change should be done (if done) only into source code but not
into output strings.|
However, i don't think this is usefull. If you setup your editor (for example eclipse into Preferences - General - Editors - Text editors) to set the tab to be 4 spaces, having 4 spaces or a tab into code will be same.
Other rules were already applied into 3.2 or dev branch. There was 14 000 checkstyle errors into 3.1.1. With current version, only 10 errors (and we can't removed them) ! This means an important work was done about style. You will find the rules defined into file dev/codesniffer/rules.xml. And reports available here:
However, some rules were discarded :
- Tab must be spaces. As explained, if tab is defined to 4 chars, there is absolutely no differences for developer, so no need to use this rule strictly.
- Having line length limited to 80 chars. This rule comes from development rules when screens were text screens limited to 80 chars (you remember the screen green and black of your old amiga or dos pc ?). This rule is, of course, obsolete and having a print taking all screen make code less clear than more.
- The rule " The closing
- Some class name or method does not match StudlyCaps or camelCase. Reason is changing this may break compatibility. So we change this, but version after version when we can. For the moment we disabled this checkstyle check.
Other rules seems to be already applied.
Le 13/06/2012 13:41, i.d & l a écrit :
Hi, is it not just something like sed 's/\t/ /' applied to the whole set of php files ?
-- Eldy (Laurent Destailleur). --------------------------------------------------------------- EMail: address@hidden Web: http://www.destailleur.fr Dolibarr (Project leader): http://www.dolibarr.org To make a donation for Dolibarr project via Paypal: address@hidden AWStats (Author) : http://awstats.sourceforge.net To make a donation for AWStats project via Paypal: address@hidden AWBot (Author) : http://awbot.sourceforge.net CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net
|[Prev in Thread]||Current Thread||[Next in Thread]|