|
From: | Laurent Destailleur (eldy) |
Subject: | Re: [Dolibarr-dev] Bug in htdocs/comm/mailing/cibles.php on line 310 |
Date: | Thu, 23 May 2013 10:04:26 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Fixed into 3.3 branch. Was already fixed into 3.4 Le 22/05/2013 23:20, Marc-Henri Pamiseux a écrit : > Hi, > > I've got a bug in a mailing. > > Warning: Missing argument 1 for > mailing_thirdparties_services_expired::getNbOfRecipients(), called in > {...}htdocs/comm/mailing/cibles.php on line 310 and defined in > {...}htdocs/core/modules/mailings/thirdparties_services_expired.modules.php > on line 182 > > With the last pull of branch 3.3 in git repository, the file cibles.php > call getNbOfRecipients() in line 310 without the first argument. > In > htdocs/core/modules/mailings/thirdparties_services_expired.modules.php i > can see this definition : > > function getNbOfRecipients($sql,$filter=1,$option='') > { > > ... > > $a=parent::getNbOfRecipients($sql); > > return $a; > } > > I think there must be a NULL default value for the first argument, > something like : > > function getNbOfRecipients($sql='',$filter=1,$option='') > { > > might be better ? > > Most of the time, this function getNbOfRecipients() is defined like > function getNbOfRecipients($sql=''), except in the line N°79 in > core/modules/mailings/modules_mailings.php and at line N°182 in > core/modules/mailings/thirdparties_services_expired.modules.php. > > In fact, only comm/mailing/cibles.php at line 310 call this > getNbOfRecipients function without any argument. > > Could you commit this change in GIT repo ? > > Best regards, > > > _______________________________________________ > Dolibarr-dev mailing list > address@hidden > https://lists.nongnu.org/mailman/listinfo/dolibarr-dev - -- Eldy (Laurent Destailleur). EMail: address@hidden Web: http://www.destailleur.fr Dolibarr (Project leader): http://www.dolibarr.org To make a donation for Dolibarr project via Paypal: address@hidden AWStats (Author) : http://awstats.sourceforge.net To make a donation for AWStats project via Paypal: address@hidden AWBot (Author) : http://awbot.sourceforge.net CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRnc2KAAoJEPwrU5wOxNNPAncH/RXyopuMEs4O6SuJpFeJSsfl TF9qyw0vTnJZh8Sxv+Hue+Y7xOBSMMEkmtPvFatA3Jpw8S15DO/8sR6PPK8rPvtq 5bFtH43BGQdjuNsFyceeewGP8IpHLFv/4/rEPQ8rC+eXbLOtJyWpGBSIMGsWmJ05 SvxVa1MucJEPFMQ6GKqlZPhChzcNycFiQHa498PURbEUM2VJjN0uUYvEVNRiG5eZ 84UwX6vGWNoJG93LPhYm0GC0KXqmQTAfHmvn323ic8O+CVsNDYjW/AC5VfAP8csH UtpoJjD1okcDIceIKiUgG4LWkGMWzEyHXFPIkIc55XsJ+LLgeIl2ACCzCfRUumc= =/WI9 -----END PGP SIGNATURE----- |
[Prev in Thread] | Current Thread | [Next in Thread] |