|Subject:||Re: [Dolibarr-dev] NPR VAT|
|Date:||Wed, 04 Sep 2013 10:39:20 +0400|
|User-agent:||Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8|
Reply to Raphël :
I looked at your fournisseur.product.class.php.patch and the changes suggested here were not in your pull requestYes i have added some fix (for example when you edit reseller price, the tva input field is always empty, it is not a npr vat problem only)
In my tree I have a bunch of references to recuperableonly all over the place.Yes, this references aren't about "product_fournisseur_price"
This field is in table llx_c_tva, llx_product and llx_product_price
what is the purpose ? remove all recuperableonly fields and references ?
I'm also suprprised to see a database field renaming without the proper code into the sql migration script in the install directory.In fact, in my pull request, they are to commit about this field :
commit be8a95a add recuperableonly field to product_fournisseur_price table
commit 5921033 rename recuperableonly field to info_bits
They are just a new field "info_bits"
Reply to Laurent :
Our main problem is that the npr feature has so few users using it than we don't have test unit for it to check feature is working correctly beteen each versionsYes it's my fault, I should have done the test before 3.4.0 released but i do not have time. For the next release, I'll try to improve it.
What's the best way to resolve npr problem's ? I must work on dev branch or on 3.4.0 branch ? What's the purpose about recuperableonly field ? ...
Actually, I have some times to work on it.
Le 03/09/2013 21:19, Destailleur Laurent a écrit :
|[Prev in Thread]||Current Thread||[Next in Thread]|