[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Dolibarr-dev] How to split Pull Request ?

From: Doursenaud , Raphaël
Subject: Re: [Dolibarr-dev] How to split Pull Request ?
Date: Thu, 10 Apr 2014 16:16:59 +0200

Yep, rule of thumb with GIT and GitHub: always create a new branch from upstream each time you're working on a new topic.
We call them "topic branches".
You inadvertedly discoverred the cool thing about pull requests, you can add more to them by simply pushing to the related branch.


2014-04-10 16:02 GMT+02:00 Marcos García <address@hidden>:

You are right, you have to create different branches.

Since the changes are pushed you cannot alter the history... Maybe creating a new branch before the change and cherry picking the commits to the newer, so that you can delete the older one...

Regards, Marcos.

El 10/04/2014 15:59, "Kevin Guerrier" <address@hidden> escribió:

How can i split my commit into many pull request ?
My first and my second commit was made before my first pull request and appeared correctly into.
But when I made another commit (adding complete head bank from other modules), it has been included into the same pull request with the same title...

How can I split it into different request ?

Should I create another branch to make different pull request ? Can I move my last commit into another pull request ?

Thanks by advance.

GUERRIER Kevin <address@hidden>

Dolibarr-dev mailing list

Dolibarr-dev mailing list

Raphaël Doursenaud
Directeur technique (CTO)
Expert certifié en déploiement Google Apps
+33 (0)5 35 53 97 13 - +33 (0)6 68 48 20 10
Technopole Hélioparc
2 avenue du Président Pierre Angot
64053 PAU CEDEX 9
SARL au capital de 7 500 € - R.C.S. PAU 528 995 921

reply via email to

[Prev in Thread] Current Thread [Next in Thread]