[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Dolibarr-dev] Duplicated vars in Societe class

From: Destailleur Laurent
Subject: Re: [Dolibarr-dev] Duplicated vars in Societe class
Date: Sun, 4 May 2014 17:02:40 +0200

Thanks for feedback.
datea was a field we should not used.

I have cleaned this with a commit.

2014-05-04 11:26 GMT+02:00 Marcos García <address@hidden>:
Hi all:

I have been checking the Societe class and I noticed 2 variables that do the same. None of them are marked as deprecated, that's why I am asking you to tell.

Societe::datec: set in line 947 ($this->db->jdate($obj->datec)
Societe::date_creation: set in line 2519 ($this->date_creation     = $this->db->jdate($obj->datec);

Societe::date_update: set in line 948 ($obj->date_update))
Societe::date_modification: set in line 2529 ($this->db->jdate($obj->datea))

What is the difference between them? I think this may be because of code standarization, but because we don't use getters and setters this could lead to outdated values... Don't you think so?

Marcos García

Dolibarr-dev mailing list

Laurent Destailleur (alias Eldy)
Social networks of my OpenSource projects:
Dolibarr Google+:
Dolibarr Facebook:
Dolibarr Twitter:
AWStats Google+:
AWStats Facebook:
AWStats Twitter:

reply via email to

[Prev in Thread] Current Thread [Next in Thread]