Re: [Dolibarr-dev] Question about codesniffer ruleset

[Marcos García]

Hi all again:

I've made a pull request with the new CodeSniffer ruleset, following PSR-2 with the exceptions declared in the wiki. I've noticed that the wiki does not make any reference to the namespaces, so I assume we do follow them (¿?)

https://github.com/Dolibarr/dolibarr/pull/1740

Regards,

 

Marcos García

address@hidden

2014-07-07 22:03 GMT+02:00 Frédéric FRANCE <address@hidden>:

Hello

I tried to add in ruleset:

    <!-- PHP code MUST NOT contain any character before the opening tag -->
    <rule ref="Generic.PHP.CharacterBeforePHPOpeningTag"/>

Merge pull request #1721 from frederic34/patch-6

but it cause a big number of errors

Fred

Le 05/07/2014 13:35, Marcos García a écrit :

Hi all:

If we are following PSR2 coding standard, then why does the ruleset.xml have only PEAR rules?

Regards,

 

Marcos García

address@hidden

_______________________________________________
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

_______________________________________________
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev