[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Dolibarr-dev] Question about isValidUrl function

From: Destailleur Laurent
Subject: Re: [Dolibarr-dev] Question about isValidUrl function
Date: Sun, 20 Jul 2014 13:23:20 +0200

So ok to keep dolibarr functions but using the native php code inside instead  (for compatibility reason + it help when native function need t obe extended)

2014-07-18 10:17 GMT+02:00 [Kreiz IT]Cédric GROSS <address@hidden>:



I agree. Just do a wrapper. And may be review also GETPOST to use also filter_var or more precisely filter_input ;)




De : dolibarr-dev-bounces+c.gross=address@hidden [mailto:dolibarr-dev-bounces+c.gross=address@hidden] De la part de Florian Henry
Envoyé : vendredi 18 juillet 2014 10:09
À : Posts about Dolibarr ERP & CRM development and coding
Objet : Re: [Dolibarr-dev] Question about isValidUrl function


I think that native PHP fonction is now OK to ne use everywhere.

Envoyer depuis mon mobile.

"Doursenaud, Raphaël" <address@hidden> a écrit :

Hi Marcos,


I wouldn't delete parameters because there may be some external modules that rely on this function.

But I think we could benefit from using it as a wrapper to php native functions and maybe deprecate it so module developers know they should use the native functions directly.


What do you think?


2014-07-17 21:23 GMT+02:00 Marcos García <address@hidden>:

Hi all:


I've been looking at isValidUrl function (located in core/lib/functions2.lib.php) and it has multiple parameters that are not used all over Dolibarr code.



Also, there's already a function in the core of PHP that does the same. Can we replace all the preg checks (that have high CPU cost) with the filter_var function or is there any reason why those checks are there?





Marcos García


Dolibarr-dev mailing list




Image supprimée par l'expéditeur.

Technopole Hélioparc

2 avenue du Président Pierre Angot

64053 PAU CEDEX 9

SARL au capital de 7 500 € - R.C.S. PAU 528 995 921

Image supprimée par l'expéditeur.Image supprimée par l'expéditeur.

Dolibarr-dev mailing list

Laurent Destailleur (alias Eldy)
Social networks of my OpenSource projects:
Dolibarr Google+:
Dolibarr Facebook:
Dolibarr Twitter:
AWStats Google+:
AWStats Facebook:
AWStats Twitter:

reply via email to

[Prev in Thread] Current Thread [Next in Thread]