[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Dolibarr-dev] dol_getmypid

From: Destailleur Laurent
Subject: Re: [Dolibarr-dev] dol_getmypid
Date: Fri, 1 Aug 2014 00:29:56 +0200

It seems what we did was not enough.
Some php instalattion does not provide the feature AND does not allow code to declare it. A very not common setup (probably need to hack php to have this) but may be result of security php addon.

Don't want to take risk, so I included the patch.
Changing code into ext lib is not a thing i like but knowing some users can't use dolibarr just because of one code line is not something pleasant...

2014-07-31 20:58 GMT+02:00 Frédéric FRANCE <address@hidden>:
Here is the french discussion why i proposed that:

On some host checking getmypid() say's function doses'nt exist but it's impossible to redeclare.
And just because of this function, you loose a potential user


Le 31/07/2014 20:26, Marcos García a écrit :
Hi all:

I've noticed a PR made by frederic ( was accepted, and so getmypid was renamed to dol_getmypid.

My question is: why was that made? The check if function does not exists before recreating the function getmypid wasn't enough?

I brought the discussion to the ML because I think it is a better place to discuss this things.

Marcos García

Dolibarr-dev mailing list

Dolibarr-dev mailing list

Laurent Destailleur (alias Eldy)
Social networks of my OpenSource projects:
Dolibarr Google+:
Dolibarr Facebook:
Dolibarr Twitter:
AWStats Google+:
AWStats Facebook:
AWStats Twitter:

reply via email to

[Prev in Thread] Current Thread [Next in Thread]