[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Dolibarr-dev] Renaming getNomUrl

From: Doursenaud , Raphaël
Subject: Re: [Dolibarr-dev] Renaming getNomUrl
Date: Tue, 14 Oct 2014 17:16:15 +0200

Hi all,

This method returns a full clickable link with either the object's name, icon or both.
With get*Url(), I expect to get a URL, not a fully formatted HTML content.
Thus, I'd prefer getLink() or getHtmlLink() because these better reflects its purpose.

+1 for the deprecated method wrapper to keep backward compatibility.

My 2 cents,

2014-10-13 17:44 GMT+02:00 Marcos García <address@hidden>:

I hope that too ;)

El 13/10/2014 17:41, "Christophe Battarel" <address@hidden> escribió:


I agree with you for the getObjectUrl function name.

BUT i really hope that the old getNomUrl function will still remains for compatibility with all the external modules that use it !!!
(of course this old function should become just a call to the new one)

My two cents

Le 13/10/2014 17:30, Marcos García a écrit :
Hi all:

Alexandre Spangaro (aspangaro) did a PR ( where some parts of the code got renamed and therefore translated to English.

I saw he translated getNomUrl function to getNameUrl, but then I thought a more appropiate name would be getObjectUrl, as we are geting the url of the object, not of the name.

What do you think?

Marcos García

Dolibarr-dev mailing list

Christophe Battarel
Responsable technique
sarl altairis
Informatique et Web en Grésivaudan
33 Grande Rue
38570 Goncelin
09 52 71 70 96 (appel local)

Dolibarr-dev mailing list

Dolibarr-dev mailing list

Raphaël Doursenaud
Directeur technique (CTO)
Expert certifié en déploiement Google Apps
+33 (0)5 35 53 97 13 - +33 (0)6 68 48 20 10
Technopole Hélioparc
2 avenue du Président Pierre Angot
64053 PAU CEDEX 9
SARL au capital de 7 500 € - R.C.S. PAU 528 995 921

reply via email to

[Prev in Thread] Current Thread [Next in Thread]