dolibarr-git
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Dolibarr-git] [Dolibarr/dolibarr] b6b873: Revert "Fix: security"


From: Laurent Destailleur
Subject: [Dolibarr-git] [Dolibarr/dolibarr] b6b873: Revert "Fix: security"
Date: Mon, 09 Apr 2012 16:25:06 -0700

  Branch: refs/heads/3.2
  Home:   https://github.com/Dolibarr/dolibarr
  Commit: b6b873cfc55fc7c773afedd266a51ef24581b7a5
      
https://github.com/Dolibarr/dolibarr/commit/b6b873cfc55fc7c773afedd266a51ef24581b7a5
  Author: Laurent Destailleur <address@hidden>
  Date:   2012-04-09 (Mon, 09 Apr 2012)

  Changed paths:
    M htdocs/admin/tools/export.php

  Log Message:
  -----------
  Revert "Fix: security"

This reverts commit 56daf57cb1a1c5f80fa9418ddd40556cf06c355d.


  Commit: 141fa014e65d9058c3da14f92c165989bf71f148
      
https://github.com/Dolibarr/dolibarr/commit/141fa014e65d9058c3da14f92c165989bf71f148
  Author: Laurent Destailleur <address@hidden>
  Date:   2012-04-09 (Mon, 09 Apr 2012)

  Changed paths:
    M htdocs/admin/tools/export.php
  M htdocs/core/lib/functions.lib.php

  Log Message:
  -----------
  Revert code because it does not fix security hole completely. Also it
does work on origin but at a transition level.
Sanitizing for command line data must not appears inside a function used
for http data. I prefer fixing this at the source and also using a rule
that clean all attacks completely instead of a rule that clean "most
problem but not all".


Compare: https://github.com/Dolibarr/dolibarr/compare/ae8b16b...141fa01

reply via email to

[Prev in Thread] Current Thread [Next in Thread]