[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [DotGNU]a small patch for approval
From: |
Rhys Weatherley |
Subject: |
Re: [DotGNU]a small patch for approval |
Date: |
Sun, 15 Sep 2002 21:11:02 +1000 |
Gopal V wrote:
> Patch: Fixes compilation for member accesses into constant valuetypes
> example:
> true.ToString();
> "hello".ToCharArray();
>
> Hopefully this is a fix, but after all I might be wrong (as this proved
> to be almost too easy ... ?)
Looks OK, although you may want to use the existing function
"ILValueTypeToType" instead of "ILMachineTypeToILType", and just
add the missing "Decimal" case. See "codegen/cg_gen.c". Then
re-run all the cscctest tests. If it doesn't break anything,
check it in and add some test cases for it.
Cheers,
Rhys.