[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-bug-tracker] bug#5670: marked as done (Bug in `momentary-string-d

From: Emacs bug Tracking System
Subject: [Emacs-bug-tracker] bug#5670: marked as done (Bug in `momentary-string-display')
Date: Wed, 03 Mar 2010 04:01:02 +0000

Your message dated Tue, 02 Mar 2010 23:00:23 -0500
with message-id <address@hidden>
and subject line Re: bug#5670: Bug in `momentary-string-display'
has caused the Emacs bug report #5670,
regarding Bug in `momentary-string-display'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact address@hidden

5670: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5670
Emacs Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Bug in `momentary-string-display' Date: Tue, 2 Mar 2010 00:52:23 +0100 User-agent: Mutt/1.5.20 (2009-08-27)
Let binding of `message' inside the function shadows one of the
arguments, leading to the momentarily inserted string (instead of the
message) being displayed in the echo area.

The patch below fixes that.

--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -2196,15 +2196,15 @@ Display MESSAGE (optional fourth arg) in the echo area.
 If MESSAGE is nil, instructions to type EXIT-CHAR are displayed there."
   (or exit-char (setq exit-char ?\s))
   (let ((ol (make-overlay pos pos))
-        (message (copy-sequence string)))
+        (str (copy-sequence string)))
-            (overlay-put ol 'after-string message)
+            (overlay-put ol 'after-string str)
             (goto-char pos)
             ;; To avoid trouble with out-of-bounds position
             (setq pos (point))
-            ;; If the message end is off screen, recenter now.
+            ;; If the string end is off screen, recenter now.
             (if (<= (window-end nil t) pos)
                 (recenter (/ (window-height) 2))))
           (message (or message "Type %s to continue editing.")

--- End Message ---
--- Begin Message --- Subject: Re: bug#5670: Bug in `momentary-string-display' Date: Tue, 02 Mar 2010 23:00:23 -0500 User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
Thank you; applied.

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]