[Emacs-bug-tracker] bug#5956: marked as done ([PATCH] cp: preserve "capabilities" when also preserving file ownership)

[GNU bug Tracking System]

Your message dated Fri, 16 Apr 2010 23:12:59 +0100
with message-id <address@hidden>
and subject line Re: bug#5956: [PATCH] cp: preserve "capabilities" when also 
preserving file ownership
has caused the GNU bug report #5956,
regarding [PATCH] cp: preserve "capabilities" when also preserving file 
ownership
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact address@hidden
immediately.)


-- 
5956: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5956
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] cp: preserve "capabilities" when also preserving file ownership Date: Fri, 16 Apr 2010 09:41:00 +0100 User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3

`sudo cp -a non-root-file copy` would not preserve capabilities.
The attached fixes this and passes all tests.

cheers,
Pádraig.

cp-capabilities.diff
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#5956: [PATCH] cp: preserve "capabilities" when also preserving	file ownership
>
>
>
>
> Date: 
>
> Fri, 16 Apr 2010 23:12:59 +0100
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; U; Linux i686; en-US;	rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3
>
>
>
>
> On 16/04/10 21:13, Jim Meyering wrote:
> > Pádraig Brady wrote:
> >> `sudo cp -a non-root-file copy` would not preserve capabilities.
> >> The attached fixes this and passes all tests.
> > ...
> >> Subject: [PATCH] cp: preserve "capabilities" when also preserving file 
> >> ownership
> >>
> >> * src/copy.c (copy_reg): Copy xattrs _after_ setting file ownership
> >> so that capabilities are not cleared when setting ownership.
> >> * tests/cp/capability: A new root test.
> >> * tests/Makefile.am (root_tests): Reference the new test.
> >> * NEWS: Mention the fix.
> > 
> > Good catch!
> > The patch looks fine.
> > Some tiny suggestions:
>
> Thanks for the review.
> I've just pushed that.
>
> cheers,
> Pádraig.
>
>
> --- End Message ---