[Emacs-bug-tracker] bug#7717: closed (24.0.50; "games" user is hardcoded in build system)

[GNU bug Tracking System]

Your message dated Wed, 29 Dec 2010 19:14:07 +0800
with message-id <address@hidden>
and subject line Re: bug#7717: 24.0.50; "games" user is hardcoded in build 
system
has caused the GNU bug report #7717,
regarding 24.0.50; "games" user is hardcoded in build system
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
7717: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7717
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.0.50; "games" user is hardcoded in build system
>
>
>
>
> Date: 
>
> Thu, 23 Dec 2010 09:36:42 +0100
>
>
>
>
> Tags: patch
>
> The build system of Emacs currently hardcodes the "games" user that is
> used for shared score files in ${localstatedir}. While usage of that
> account name may be widespread, it is not universal. For example, in
> Gentoo the name is configurable.
>
> Since a variable "gameuser" and the autoconf plumbing for it already
> exist, the only missing piece is a configure option. See attached
> patch.
>
>
> 2010-12-22  Ulrich Mueller  <address@hidden>
>
>         * configure.in: Make gameuser configurable.
>
> --- emacs-orig/configure.in
> +++ emacs/configure.in
> @@ -45,8 +45,6 @@
>  docdir='${datadir}/emacs/${version}/etc'
>  gamedir='${localstatedir}/games/emacs'
>  
> -gameuser=games
> -
>  dnl OPTION_DEFAULT_OFF(NAME, HELP-STRING)
>  dnl Create a new --with option that defaults to being disabled.
>  dnl NAME is the base name of the option.  The shell variable with_NAME
> @@ -203,6 +201,13 @@
>  The default is /usr/lib, or /usr/lib64 on some platforms.])])
>  CRT_DIR="${with_crt_dir}"
>  
> +AC_ARG_WITH(gameuser,
> +[AS_HELP_STRING([--with-gameuser=USER],
> +  [user for shared score files; default games])])
> +test "X${with_gameuser}" != X && test "${with_gameuser}" != yes \
> +  && gameuser="${with_gameuser}"
> +test "X$gameuser" = X && gameuser=games
> +
>  AC_ARG_WITH([gnustep-conf],dnl
>  [AS_HELP_STRING([--with-gnustep-conf=PATH],[path to GNUstep.conf; default 
> $GNUSTEP_CONFIG_FILE, or /etc/GNUstep/GNUstep.conf])])
>  test "X${with_gnustep_conf}" != X && test "${with_gnustep_conf}" != yes && \
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#7717: 24.0.50; "games" user is hardcoded in build system
>
>
>
>
> Date: 
>
> Wed, 29 Dec 2010 19:14:07 +0800
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
>
>
>
>
> Ulrich Mueller <address@hidden> writes:
>
> > The build system of Emacs currently hardcodes the "games" user that is
> > used for shared score files in ${localstatedir}. While usage of that
> > account name may be widespread, it is not universal. For example, in
> > Gentoo the name is configurable.
> >
> > Since a variable "gameuser" and the autoconf plumbing for it already
> > exist, the only missing piece is a configure option. See attached
> > patch.
>
> Looks reasonable.  Committed to trunk; thanks.
>
>
> --- End Message ---