[debbugs-tracker] bug#9901: closed (xg_win_to_widget uninitialized access)

[GNU bug Tracking System]

Your message dated Sun, 30 Oct 2011 18:32:16 +0100
with message-id <address@hidden>
and subject line Re: bug#9901: xg_win_to_widget uninitialized access
has caused the debbugs.gnu.org bug report #9901,
regarding xg_win_to_widget uninitialized access
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
9901: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9901
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> xg_win_to_widget uninitialized access
>
>
>
>
> Date: 
>
> Fri, 28 Oct 2011 21:59:02 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)
>
>
>
>
> valgrind gives a warning for an uninitialized access in
> xg_win_to_widget for the gtk_get_event_widget call.
>
>
>  if (gdkwin)
>     {
>       GdkEvent event;
>       event.any.window = gdkwin;
>       gwdesc = gtk_get_event_widget (&event);
>     }
>
> gtk_get_event_widget is (in gtk3):
>
> GtkWidget*
> gtk_get_event_widget (GdkEvent *event)
> {
>   GtkWidget *widget;
>   gpointer widget_ptr;
>
>   widget = NULL;
>   if (event && event->any.window &&
>       (event->type == GDK_DESTROY || !gdk_window_is_destroyed
>   (event->any.window)))
>     {
>       gdk_window_get_user_data (event->any.window, &widget_ptr);
>       widget = widget_ptr;
>     }
>
>   return widget;
> }
>
> so indeed event->type is uninitialized.
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#9901: xg_win_to_widget uninitialized access
>
>
>
>
> Date: 
>
> Sun, 30 Oct 2011 18:32:16 +0100
>
>
>
>
> Fixed.
>
>         Jan D.
>
> 29 okt 2011 kl. 03:59 skrev Dan Nicolaescu:
>
> > valgrind gives a warning for an uninitialized access in
> > xg_win_to_widget for the gtk_get_event_widget call.
> > 
> > 
> > if (gdkwin)
> >    {
> >      GdkEvent event;
> >      event.any.window = gdkwin;
> >      gwdesc = gtk_get_event_widget (&event);
> >    }
> > 
> > gtk_get_event_widget is (in gtk3):
> > 
> > GtkWidget*
> > gtk_get_event_widget (GdkEvent *event)
> > {
> >  GtkWidget *widget;
> >  gpointer widget_ptr;
> > 
> >  widget = NULL;
> >  if (event && event->any.window &&
> >      (event->type == GDK_DESTROY || !gdk_window_is_destroyed
> >  (event->any.window)))
> >    {
> >      gdk_window_get_user_data (event->any.window, &widget_ptr);
> >      widget = widget_ptr;
> >    }
> > 
> >  return widget;
> > }
> > 
> > so indeed event->type is uninitialized.
> > 
> > 
> > 
>
>
>
> --- End Message ---