[debbugs-tracker] bug#10592: closed (movemail.c's error function and certain compiler flags)

[GNU bug Tracking System]

Your message dated Mon, 30 Jan 2012 20:22:03 -0800
with message-id <address@hidden>
and subject line Re: bug#10592: Bug#655118: Please enabled hardened build flags
has caused the debbugs.gnu.org bug report #10592,
regarding movemail.c's error function and certain compiler flags
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
10592: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10592
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: Bug#655118: Please enabled hardened build flags
>
>
>
>
> Date: 
>
> Mon, 23 Jan 2012 23:05:26 -0600
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)
>
>
>
>
> (Sorry, accidentally hit send too early.)
>
> Mortiz updated Emacs to support -Wformat -Wformat-security
> -Werror=format-security.
>
> Here are the relevant changes (further details are available at
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655118):
>
> diff -aur emacs23-23.3+1.orig/lib-src/movemail.c 
> emacs23-23.3+1/lib-src/movemail.c
> --- emacs23-23.3+1.orig/lib-src/movemail.c      2011-12-29 05:07:27.000000000 
> +0100
> +++ emacs23-23.3+1/lib-src/movemail.c   2012-01-08 17:31:22.000000000 +0100
> @@ -615,11 +615,11 @@
>  {
>    fprintf (stderr, "movemail: ");
>    if (s3)
> -    fprintf (stderr, s1, s2, s3);
> +    fprintf (stderr, "%s%s%s", s1, s2, s3);
>    else if (s2)
> -    fprintf (stderr, s1, s2);
> +    fprintf (stderr, "%s%s", s1, s2);
>    else
> -    fprintf (stderr, s1);
> +    fprintf (stderr, "%s", s1);
>    fprintf (stderr, "\n");
>  }
>  
> Thanks
> -- 
> Rob Browning
> rlb @defaultvalue.org and @debian.org
> GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#10592: Bug#655118: Please enabled hardened build flags
>
>
>
>
> Date: 
>
> Mon, 30 Jan 2012 20:22:03 -0800
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux i686;	rv:9.0) Gecko/20111229 Thunderbird/9.0
>
>
>
>
> I am not observing this problem in the Emacs trunk, with either
> GCC 4.6.2 or GCC 4.7.0 20120127 (experimental), when I compile
> with -Wformat -Wformat-security.  I suspect the problem has
> already been fixed in the trunk in a different way, by
> rewriting movemail to use prototypes.  I'm therefore taking
> the liberty of marking this bug as fixed in the Emacs bug
> database; please feel free to reopen it if I've misunderstood
> the situation.
>
>
> --- End Message ---