[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#11051: closed (24.0.94; `widget-complete': Remove

From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#11051: closed (24.0.94; `widget-complete': Remove quote for `widget-complete-field')
Date: Wed, 21 Mar 2012 02:48:02 +0000

Your message dated Tue, 20 Mar 2012 22:16:27 -0400
with message-id <address@hidden>
and subject line Re: bug#11051: 24.0.94; `widget-complete': Remove quote for 
has caused the debbugs.gnu.org bug report #11051,
regarding 24.0.94; `widget-complete': Remove quote for `widget-complete-field'
to be marked as done.

(If you believe you have received this mail in error, please contact

11051: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11051
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 24.0.94; `widget-complete': Remove quote for `widget-complete-field' Date: Tue, 20 Mar 2012 09:46:22 -0700
This code in wid-edit.el is wrong:
(defun widget-complete ()
  "Complete content of editable field from point.
When not inside a field, signal an error."
  (let ((data (widget-completions-at-point)))
     ((functionp data) (funcall data))
     ((consp data)
      (let ((completion-extra-properties (nth 3 data)))
        (completion-in-region (nth 0 data) (nth 1 data) (nth 2 data)
                              (plist-get completion-extra-properties
     ((widget-field-find (point))
      ;; This defaulting used to be performed in widget-default-complete, but
      ;; it seems more appropriate here than in widget-default-completions.
      (call-interactively 'widget-complete-field))
;;; WRONG - remove quote  ^
      (error "Not in an editable field")))))
`widget-complete-field' is not a command.  Its value is a command.

In GNU Emacs (i386-mingw-nt5.1.2600)
 of 2012-03-19 on MARVIN
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.6) --no-opt --enable-checking --cflags

--- End Message ---
--- Begin Message --- Subject: Re: bug#11051: 24.0.94; `widget-complete': Remove quote for `widget-complete-field' Date: Tue, 20 Mar 2012 22:16:27 -0400 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux)
> `widget-complete-field' is not a command.  Its value is a command.

Indeed, this was completely broken, and there doesn't seem to be much of
a fix.  I just removed it: after all, the fact that it didn't work
hasn't seemed to cause much uproar; and with the new code there are
other ways to get similar results.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]