[debbugs-tracker] bug#11051: closed (24.0.94; `widget-complete': Remove quote for `widget-complete-field')

[GNU bug Tracking System]

Your message dated Tue, 20 Mar 2012 22:16:27 -0400
with message-id <address@hidden>
and subject line Re: bug#11051: 24.0.94; `widget-complete': Remove quote for 
`widget-complete-field'
has caused the debbugs.gnu.org bug report #11051,
regarding 24.0.94; `widget-complete': Remove quote for `widget-complete-field'
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
11051: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11051
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.0.94; `widget-complete': Remove quote for `widget-complete-field'
>
>
>
>
> Date: 
>
> Tue, 20 Mar 2012 09:46:22 -0700
>
>
>
>
> This code in wid-edit.el is wrong:
>  
> (defun widget-complete ()
>   "Complete content of editable field from point.
> When not inside a field, signal an error."
>   (interactive)
>   (let ((data (widget-completions-at-point)))
>     (cond
>      ((functionp data) (funcall data))
>      ((consp data)
>       (let ((completion-extra-properties (nth 3 data)))
>         (completion-in-region (nth 0 data) (nth 1 data) (nth 2 data)
>                               (plist-get completion-extra-properties
>                                          :predicate))))
>      ((widget-field-find (point))
>       ;; This defaulting used to be performed in widget-default-complete, but
>       ;; it seems more appropriate here than in widget-default-completions.
>       (call-interactively 'widget-complete-field))
>  
> ;;; WRONG - remove quote  ^
>  
>      (t
>       (error "Not in an editable field")))))
>  
> `widget-complete-field' is not a command.  Its value is a command.
>
> In GNU Emacs 24.0.94.1 (i386-mingw-nt5.1.2600)
>  of 2012-03-19 on MARVIN
> Windowing system distributor `Microsoft Corp.', version 5.1.2600
> Configured using:
>  `configure --with-gcc (4.6) --no-opt --enable-checking --cflags
>  -ID:/devel/emacs/libs/libXpm-3.5.8/include
>  -ID:/devel/emacs/libs/libXpm-3.5.8/src
>  -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
>  -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
>  -ID:/devel/emacs/libs/giflib-4.1.4-1/include
>  -ID:/devel/emacs/libs/jpeg-6b-4/include
>  -ID:/devel/emacs/libs/tiff-3.8.2-1/include
>  -ID:/devel/emacs/libs/gnutls-3.0.9/include'
>  
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#11051: 24.0.94;	`widget-complete': Remove quote for `widget-complete-field'
>
>
>
>
> Date: 
>
> Tue, 20 Mar 2012 22:16:27 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux)
>
>
>
>
> > `widget-complete-field' is not a command.  Its value is a command.
>
> Indeed, this was completely broken, and there doesn't seem to be much of
> a fix.  I just removed it: after all, the fact that it didn't work
> hasn't seemed to cause much uproar; and with the new code there are
> other ways to get similar results.
>
>
>         Stefan
>
>
>
>
>
> --- End Message ---