[debbugs-tracker] bug#11914: closed (Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h)

[GNU bug Tracking System]

Your message dated Wed, 11 Jul 2012 13:41:40 -0700
with message-id <address@hidden>
and subject line Re: bug#11914: Unnecessary '#define HAVE_LIBKSTAT' in 
src/s/sol2-6.h
has caused the debbugs.gnu.org bug report #11914,
regarding Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
11914: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11914
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h
>
>
>
>
> Date: 
>
> Wed, 11 Jul 2012 15:14:18 -0400
>
>
>
>
> User-agent: 
>
> Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
>
>
>
>
> Package: emacs
> Version: 24.1.50
> Severity: minor
>
> (Very similar to bug#11905)
>
> src/s/sol2-6.h does this:
>     
>     /* Prefer kstat over kvm in getloadavg.c, kstat doesn't require root.
>        address@hidden, 7/21/97.  Don't redefine if already defined
>        (e.g., by config.h). */
>     #ifndef HAVE_LIBKSTAT
>     #define HAVE_LIBKSTAT
>     #endif
>
> The only place in Emacs that references '#ifdef HAVE_LIBKSTAT' is
> lib/getloadavg.c, from Gnulib. It looks like Gnulib is already handling
> this properly via configure checks (?), so there is no need for Emacs's
> src/s/sol2-6.h to define HAVE_LIBKSTAT.
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#11914: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h
>
>
>
>
> Date: 
>
> Wed, 11 Jul 2012 13:41:40 -0700
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux i686;	rv:13.0) Gecko/20120615 Thunderbird/13.0.1
>
>
>
>
> On 07/11/2012 12:14 PM, Glenn Morris wrote:
> > there is no need for Emacs's
> > src/s/sol2-6.h to define HAVE_LIBKSTAT.
>
> Yes, thanks, I made that change in trunk bzr 109034.
>
>
> --- End Message ---