[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#7533: closed (24.0.50; `dired-mark-pop-up': delete

From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#7533: closed (24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames')
Date: Wed, 03 Oct 2012 09:13:02 +0000

Your message dated Wed, 03 Oct 2012 11:11:52 +0200
with message-id <address@hidden>
and subject line Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame 
afterwards if `pop-up-frames'
has caused the debbugs.gnu.org bug report #7533,
regarding 24.0.50; `dired-mark-pop-up': delete frame afterwards if 
to be marked as done.

(If you believe you have received this mail in error, please contact

7533: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7533
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Thu, 2 Dec 2010 10:35:41 -0800
This is another one of those annoyances that come from not testing with
non-nil `pop-up-frames' (just a guess).
emacs -Q
M-x set-variable RET pop-up-frames RET t RET
In Dired, flag several files for deletion, then hit `x'.
Answer `yes' or `no'.
When you hit `x' buffer *Deletions* pops up in its own frame, as it
should.  When you type `yes' or `no', the frame should disappear.  It
should be deleted.  The last part of `dired-mark-pop-up' should be
something like this:
  (dired-pop-to-buffer bufname)
  (apply function args)
  (if (one-window-p) (delete-frame) (delete-window))) ; <===== NEW
If you don't think the `delete-window' is needed, then just use
(when (one-window-p) (delete-frame)).
The important thing, for me, is that the frame that was created just to
show the files that will be deleted (or whatever) goes away.  It should
be only a _temporary_ frame because its only raison d'etre is as part of
the deletion etc. _dialog_.
[Martin will explain that a different test from `one-window-p' is more
appropriate. ;-)  IIRC, he generally prefers something like this to
(one-window-p win): (eq win (frame-root-window (window-frame win))).]
In GNU Emacs (i386-mingw-nt5.1.2600)
 of 2010-11-30 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags

--- End Message ---
--- Begin Message --- Subject: Re: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Wed, 03 Oct 2012 11:11:52 +0200
This should have been fixed in revision 109863 on Emacs trunk.

Bug closed.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]