[debbugs-tracker] bug#13507: closed (small patch for 1.13.1 t/lisp-flags.sh)

[GNU bug Tracking System]

Your message dated Mon, 21 Jan 2013 13:37:45 +0100
with message-id <address@hidden>
and subject line Re: bug#13507: small patch for 1.13.1 t/lisp-flags.sh
has caused the debbugs.gnu.org bug report #13507,
regarding small patch for 1.13.1 t/lisp-flags.sh
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
13507: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13507
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: small patch for 1.13.1 t/lisp-flags.sh Date: Sun, 20 Jan 2013 19:05:37 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)

Here is a suitable ChangeLog entry:

2013-01-20  Thien-Thi Nguyen  <address@hidden>  (tiny change)

        Don't get fooled when running "make check" inside Emacs.

        Some versions of Emacs set the env var 'EMACS' to 't'
        for child processes.  Thus, when running from inside Emacs,
        '$(MAKE) -e' erroneously allows the 't' to override the one
        in the Makefile.  This change avoids that problem.

        * t/lisp-flags.sh: Unset var 'EMACS'.

Here is the patch, proper:

diff -u lisp-flags.sh\~ lisp-flags.sh
--- lisp-flags.sh~      2012-12-31 21:13:40.000000000 +0100
+++ lisp-flags.sh       2013-01-20 18:54:18.000000000 +0100
@@ -28,6 +28,9 @@
 AC_OUTPUT
 EOF

+# Don't get fooled when running as an Emacs subprocess.
+unset EMACS
+
 $ACLOCAL
 $AUTOCONF
 $AUTOMAKE --add-missing

Diff finished.  Sun Jan 20 18:55:14 2013

With this change (and a few hours waiting on this old slow computer), i
am able to see GNU Automake 1.13.1 pass "make check".

-- 
Thien-Thi Nguyen ..................................... GPG key: 4C807502
.                  NB: ttn at glug dot org is not me                   .
.                 (and has not been since 2007 or so)                  .
.                        ACCEPT NO SUBSTITUTES                         .
........... please send technical questions to mailing lists ...........

pgpBQJbMbVUbp.pgp
Description: PGP signature

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#13507: small patch for 1.13.1 t/lisp-flags.sh
>
>
>
>
> Date: 
>
> Mon, 21 Jan 2013 13:37:45 +0100
>
>
>
>
> On 01/20/2013 07:05 PM, Thien-Thi Nguyen wrote:
> > Here is a suitable ChangeLog entry:
> > 
> > 2013-01-20  Thien-Thi Nguyen  <address@hidden>  (tiny change)
> > 
> >       Don't get fooled when running "make check" inside Emacs.
> > 
> >       Some versions of Emacs set the env var 'EMACS' to 't'
> >       for child processes.  Thus, when running from inside Emacs,
> >       '$(MAKE) -e' erroneously allows the 't' to override the one
> >       in the Makefile.  This change avoids that problem.
> > 
> >       * t/lisp-flags.sh: Unset var 'EMACS'.
> > 
> > Here is the patch, proper:
> >
> Applied, thanks.  I'm thus closing this report.
>
> Regards,
>   Stefano
>
>
> --- End Message ---