[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[debbugs-tracker] bug#13882: closed (24.2; saveplace.el limit drop least
GNU bug Tracking System
[debbugs-tracker] bug#13882: closed (24.2; saveplace.el limit drop least recently used)
Wed, 13 Mar 2013 19:01:01 +0000
Your message dated Wed, 13 Mar 2013 13:59:12 -0500
with message-id <address@hidden>
and subject line Re: bug#13882: 24.2; saveplace.el limit drop least recently
has caused the debbugs.gnu.org bug report #13882,
regarding 24.2; saveplace.el limit drop least recently used
to be marked as done.
(If you believe you have received this mail in error, please contact
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message ---
24.2; saveplace.el limit drop least recently used
Wed, 06 Mar 2013 07:49:14 +1100
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
When saveplace.el reaches save-place-limit, the file positions retained
via ~/.emacs-places are the first limit-many in alphabetical order.
I hoped instead it would be the first limit-many most recently used.
Ie. drop the least recently visited files in order to enforce the limit.
I struck this when I reached my save-place-limit with lots of files I
had visited long ago but which happened to be alphabetically before ones
I was visiting now. The save-place feature no longer saved places
across sessions for files I now visited.
The effect can be seen by setting a small limit per init.el below. Then
foo.el to visit three files successively
HOME=`pwd` emacs -Q -l ./init.el -l ./foo.el
This leaves .emacs-places (in the current directory due to faked $HOME)
(("/tmp/aa" . 4)
("/tmp/bb" . 4)
("/tmp/cc" . 4))
Notice /tmp/cc was the most recently visited file but it's at the end of
the list and will be truncated when load-save-place-alist-from-file
enforces save-place-limit of 2.
HOME=`pwd` emacs -Q -l ./init.el /tmp/cc
point is at start of buffer /tmp/cc
I hoped it would be at the end from the last visit
Note that you must exit and restart emacs to see the effect, because
save-place-limit is only enforced by load-save-place-alist-from-file.
Within a session there's no limit, only in reading the .emacs-places
file on restarting emacs.
I get some joy from not sorting save-place-alist when saving per change
I believe save-place-to-alist keeps save-place-alist in "most recent
first" order (by delq and re-push to move an existing entry to the
start), and that that order should be preserved when saving.
2013-03-04 Kevin Ryde <address@hidden>
* saveplace.el (save-place-alist-to-file): Don't `sort'
save-place-alist alphabetically, keep it in "most recent first" order.
This ensures save-place-limit drops the least recently visited files,
not the alphabetically last files. Dropping alphabetically last files
had meant save-place stopped working across sessions after
.emacs-places filled with alphabetically early names.
Description: Text Data
In GNU Emacs 24.2.1 (i486-pc-linux-gnu, GTK+ Version 2.24.10)
of 2012-09-10 on biber, modified by Debian
`configure '--build' 'i486-linux-gnu' '--build' 'i486-linux-gnu'
'--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib'
'build_alias=i486-linux-gnu' 'CFLAGS=-g -O2 -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall'
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: en_AU
value of $XMODIFIERS: nil
default enable-multibyte-characters: t
--- End Message ---
--- Begin Message ---
Re: bug#13882: 24.2; saveplace.el limit drop least recently used
Wed, 13 Mar 2013 13:59:12 -0500
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
Kevin Ryde <address@hidden> writes:
>Ian Dalton <address@hidden> writes:
>> I no longer use this setup, so I don't know how useful a change it was. I
>> think that the Unison UI had some kind of option to do guided file merges,
>> but it only worked for the usual simple line-oriented diff.
>Hmm. Making the file line-wise probably helped, but I imagine there's
>no file format which could give the perfect result from the usual
>diff/patch contextual merges.
>How about keeping the line-by-line pretty print for everyone's
>readability, but drop the sort since it's actively harmful, and leave
>anything more for future thought.
Done; see revision below. Thanks, Dmitry, Kevin, and Ian, for your
thorough & patient explanations.
committer: Karl Fogel <address@hidden>
branch nick: trunk
timestamp: Wed 2013-03-13 13:54:05 -0500
* saveplace.el (save-place-alist-to-file): Don't sort
`save-place-alist', just pretty-print it (bug#13882).
--- End Message ---
|[Prev in Thread]
||[Next in Thread]|
- [debbugs-tracker] bug#13882: closed (24.2; saveplace.el limit drop least recently used),
GNU bug Tracking System <=