[debbugs-tracker] bug#14714: closed (24.3.50; `isearch-filter-predicate(s)')

[GNU bug Tracking System]

Your message dated Mon, 05 Aug 2013 14:07:33 -0400
with message-id <address@hidden>
and subject line Re: bug#14714: 24.3.50; `isearch-filter-predicate(s)'
has caused the debbugs.gnu.org bug report #14714,
regarding 24.3.50; `isearch-filter-predicate(s)'
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
14714: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14714
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.3.50; `isearch-filter-predicate(s)'
>
>
>
>
> Date: 
>
> Tue, 25 Jun 2013 10:26:15 -0700 (PDT)
>
>
>
>
> Problem similar to that of bug #14712, regarding obsolescence, but I
> think there is a code problem also.
>
> 1. `isearch-filter-predicates' should not be an _alias_ for
> `isearch-filter-predicate'.  The former cannot just replace the latter.
>
> 2. I think one cannot currently use a single predicate as the value of
> `isearch-filter-predicates'.  There is one place in the code where that
> might work, because of this:
>
> (if (consp isearch-filter-predicates)
>     isearch-filter-predicates
>   (list isearch-filter-predicates))
>
> (But what if isearch-filter-predicates is nil?  You get `(nil)', which I
> think is wrong.)
>
> And in other places it should not work at all.  E.g.:
>
> (run-hook-with-args-until-failure
>   'isearch-filter-predicates
>   (match-beginning 0) (match-end 0))
>
> To make it work throughout, I think you would need to do something like this:
>
> (when (and isearch-filter-predicates
>            (atom isearch-filter-predicates))
>   (setq isearch-filter-predicates (list isearch-filter-predicates)))
>
> IOW, at the outset, convert an atomic (and non-nil) value to a cons.
>
>
>
>
>
>
> In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
>  of 2013-06-20 on ODIEONE
> Bzr revision: 113100 address@hidden
> Windowing system distributor `Microsoft Corp.', version 6.1.7601
> Configured using:
>  `configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
>  CFLAGS=-O0 -g3 LDFLAGS=-Lc:/Devel/emacs/lib
>  CPPFLAGS=-Ic:/Devel/emacs/include'
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#14714: 24.3.50; `isearch-filter-predicate(s)'
>
>
>
>
> Date: 
>
> Mon, 05 Aug 2013 14:07:33 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
>
>
>
>
> I have now reverted to isearch-filter-predicate.
>
> >> works fine, but
> >> (advice-member-p #'test-a 'isearch-filter-predicate)
> >> returns nil.
>
> Actually, I changed the code in a way that doesn't require
> advice-(function-)member-p.
>
>
>         Stefan
>
>
> --- End Message ---