[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#16075: closed (ls/stat-free-color.sh fails on AArc

From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#16075: closed (ls/stat-free-color.sh fails on AArch64 architecture)
Date: Sat, 07 Dec 2013 15:22:02 +0000

Your message dated Sat, 07 Dec 2013 15:21:11 +0000
with message-id <address@hidden>
and subject line Re: bug#16075: ls/stat-free-color.sh fails on AArch64 
has caused the debbugs.gnu.org bug report #16075,
regarding ls/stat-free-color.sh fails on AArch64 architecture
to be marked as done.

(If you believe you have received this mail in error, please contact

16075: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16075
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: ls/stat-free-color.sh fails on AArch64 architecture Date: Fri, 06 Dec 2013 16:50:04 +0100 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
Test checks for use of stat,lstat,stat64,lstat64 syscalls. But on
AArch64 it is using statfs64 and newfstatat calls so test fails.

log and log-help attached

Commands used:
strace -o log ls --color=always >/dev/null
strace -o log-help ls --help >/dev/null

Attachment: log-help
Description: Text document

Attachment: log
Description: Text document

--- End Message ---
--- Begin Message --- Subject: Re: bug#16075: ls/stat-free-color.sh fails on AArch64 architecture Date: Sat, 07 Dec 2013 15:21:11 +0000 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
On 12/06/2013 09:12 PM, Pádraig Brady wrote:
> On 12/06/2013 08:58 PM, Bernhard Voelker wrote:
>> On 12/06/2013 06:45 PM, Pádraig Brady wrote:
>>> Even at that the test is still brittle,
>>> as the guard only checks that `strace -e stat` works.
>>> Also it's conceivable that on some edge cases there
>>> may be more than one stat call used in this case.
>> I must confess that I don't understand this, i.e. in which circumstances
>> this test would fail as it has been working long enough, and now just
>> is ported to another architecture.
> So I'm worried that the system might have a version
> of strace that doesn't support say newfstatat for example.
> Now my removing of the -e ... above will avoid the immediate:
>   strace: invalid system call `newfstatat'
> But strace may then output something that `grep stat..` doesn't match,
> thuse messing up the counts and failing the test.
> I'll sleep on it as I'm rushing off now.

I going with the attached which should handle everything,
even diagnosis of unhandled "stat" calls.


Attachment: newfstatat.patch
Description: Text Data

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]