[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#16035: closed (24.3.50; Custom isearch broken on t

From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#16035: closed (24.3.50; Custom isearch broken on trunk (e.g. change-log-mode))
Date: Wed, 11 Dec 2013 00:16:02 +0000

Your message dated Wed, 11 Dec 2013 02:12:07 +0200
with message-id <address@hidden>
and subject line Re: bug#16035: 24.3.50; Custom isearch broken on trunk (e.g. 
has caused the debbugs.gnu.org bug report #16035,
regarding 24.3.50; Custom isearch broken on trunk (e.g. change-log-mode)
to be marked as done.

(If you believe you have received this mail in error, please contact

16035: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16035
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 24.3.50; Custom isearch broken on trunk (e.g. change-log-mode) Date: Tue, 3 Dec 2013 10:38:50 +0100
Recent changes in the isearch package has made packages that customize isearch fail.

Case 1:

change-log-mode customizes isearch so that you could search multiple files.

    Emacs -Q lisp/ChangeLog
    C-s refresh-d

Here, the symbol "font-lock-refresh-defaults" in ChangeLog.16 has been found. C-a typically exits isearch, however, now it doesn't. You can see this on the fact that the isearch highlight is still active and when more characters are typed, they are added to the search string.

This broke on revision 114586.

Log for revision 114586:

fixes bug: http://debbugs.gnu.org/15200

committer: Juri Linkov <address@hidden>

branch nick: trunk

timestamp: Wed 2013-10-09 02:20:12 +0300


  * lisp/isearch.el (isearch-help-map, isearch-mode-map): Don't bind [t]

  to isearch-other-control-char.

  (isearch-mode): Add isearch-pre-command-hook to pre-command-hook

  and isearch-post-command-hook to post-command-hook.

  (isearch-done): Remove isearch-pre-command-hook from pre-command-hook

  and isearch-post-command-hook from post-command-hook.



  (isearch-lookup-scroll-key, isearch-other-control-char)

  (isearch-other-meta-char): Remove functions.

  (isearch-pre-command-hook, isearch-post-command-hook):

  New functions based on isearch-other-meta-char rewritten

  relying on the new behavior of overriding-terminal-local-map

  that does not replace the local keymaps any more.

Case 2:

isearch in the popular third-part package "folding" is broken, same symptoms as above. (If you don't have it I can supply a copy.)

    ./nextstep/Emacs.app/Contents/MacOS/Emacs -Q folding.el -l folding.el
    M-x folding-mode RET
    C-s defvar

This broke in revision 114633.

Log for 114633:

committer: Stefan Monnier <address@hidden>

branch nick: trunk

timestamp: Fri 2013-10-11 21:10:25 -0400


  * lisp/isearch.el (isearch-pre-command-hook): Don't build in knowledge about

  internals of universal-argument.

    -- Anders Lindgren

In GNU Emacs (x86_64-apple-darwin13.0.0, NS apple-appkit-1265.00)
 of 2013-12-03 on macpro.lan
Bzr revision: 115300 address@hidden
Windowing system distributor `Apple', version 10.3.1265
Configured using:
 `configure --with-ns'

Important settings:
  value of $LC_CTYPE: UTF-8
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Change Log

Minor modes in effect:
  bug-reference-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-s r e f r e s h - d C-s C-a <up> d C-g C-g C-g C-h 
v e m a c z - b <backspace> <backspace> <backspace> 
s - b z <tab> <return> C-x 1 <menu-bar> <help-menu> 

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Quit [2 times]
Type C-x 1 to delete the help window.

Load-path shadows:
None found.

(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils help-mode easymenu help-fns misearch multi-isearch
vc-bzr bug-reference add-log time-date tooltip electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset
image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode
register page menu-bar rfn-eshadow timer select scroll-bar mouse
jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
cocoa ns multi-tty emacs)

--- End Message ---
--- Begin Message --- Subject: Re: bug#16035: 24.3.50; Custom isearch broken on trunk (e.g. change-log-mode) Date: Wed, 11 Dec 2013 02:12:07 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu)
> Now I discovered another case that fails to move point
> after exiting Isearch.  Running `multi-isearch-buffers'
> and typing e.g. `C-a' exits Isearch but doesn't move point
> to the beginning of the line.
> Exactly the same problem exists in `dired-isearch-filenames'
> that let-binds `dired-isearch-filenames' and calls `isearch-forward'
> without NO-RECURSIVE-EDIT.  And in `comint-history-isearch-backward'
> that let-binds `comint-history-isearch'.

I fixed this case as well.  Multi-buffer and multi-file search
can set the buffer list globally.  And comint.el and dired-aux.el
don't need the global value - they use the let-bound value
only in a setup hook.

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]