[debbugs-tracker] bug#14179: closed ([PATCH] hi-lock: more appropriate use of font-locking)

[GNU bug Tracking System]

Your message dated Fri, 20 Dec 2013 21:47:16 +0200
with message-id <address@hidden>
and subject line Re: bug#14179: [PATCH] hi-lock: more appropriate use of 
font-locking
has caused the debbugs.gnu.org bug report #14179,
regarding [PATCH] hi-lock: more appropriate use of font-locking
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
14179: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14179
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] hi-lock: more appropriate use of font-locking Date: Thu, 11 Apr 2013 05:19:13 +0100

Most modes that use custom fontification (ex occur-mode), won't turn the font-lock-mode off. So hi-lock would add a keyword, and remove all existing fontification. The below patch fixes this behaviour.

Evgeni

Modified   lisp/hi-lock.el

diff --git a/lisp/hi-lock.el b/lisp/hi-lock.el

index e2dc4ea..e16ed76 100644

--- a/lisp/hi-lock.el

+++ b/lisp/hi-lock.el

@@ -689,7 +689,7 @@ Otherwise, read face name from minibuffer with completion and history."

     ;; Refuse to highlight a text that is already highlighted.

     (unless (assoc regexp hi-lock-interactive-patterns)

       (push pattern hi-lock-interactive-patterns)

-      (if font-lock-mode

+      (if (and font-lock-mode (font-lock-specified-p major-mode))

   (progn

     (font-lock-add-keywords nil (list pattern) t)

     (font-lock-fontify-buffer))

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#14179: [PATCH] hi-lock: more appropriate use of font-locking
>
>
>
>
> Date: 
>
> Fri, 20 Dec 2013 21:47:16 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu)
>
>
>
>
> > Most modes that use custom fontification (ex occur-mode), won't turn the
> > font-lock-mode off. So hi-lock would add a keyword, and remove all existing
> > fontification. The below patch fixes this behaviour.
>
> Thanks, fixed.
>
>
> --- End Message ---