[debbugs-tracker] bug#18237: closed (Small fix for MSDOS)

[GNU bug Tracking System]

Your message dated Sun, 10 Aug 2014 19:42:14 +0100
with message-id <address@hidden>
and subject line Re: bug#18237: Small fix for MSDOS
has caused the debbugs.gnu.org bug report #18237,
regarding Small fix for MSDOS
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
18237: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18237
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Small fix for MSDOS Date: Sun, 10 Aug 2014 17:40:24 +0100

The following patch helps in the case when a sockets library is installed; in my case, ls080b.zip from the DJGPP site:

=== modified file 'src/msdos.c'
--- src/msdos.c    2014-08-09 16:12:33 +0000
+++ src/msdos.c    2014-08-09 21:51:56 +0000
@@ -4016,7 +4017,7 @@
 #endif
 
 
-#ifndef HAVE_SELECT
+#ifndef HAVE_SYS_SELECT_H
 #include "sysselect.h"
 
 /* This yields the rest of the current time slice to the task manager.

The reasoning is that having select doesn't imply having the sys/select.h functionality that the following code emulates.

Does that look OK to install?

--
http://rrt.sc3d.org

--- End Message ---

--- Begin Message --- Subject: Re: bug#18237: Small fix for MSDOS Date: Sun, 10 Aug 2014 19:42:14 +0100

On 10 August 2014 19:26, Eli Zaretskii <address@hidden> wrote:

I'd prefer that all the changes for such a build be committed at once
together, not bit by bit, and only if you eventually succeed to
produce a working binary using this method.

Sorry, I was trying to separate my patch into parts with different implications (e.g. no effect on the current DOS build system; some effect on that system but not more generally; more general changes); but instead I'll concentrate on producing a single patch that, as you say, results in a working binary.

 

> I think you're also saying that I should test both HAVE_SELECT &&
> HAVE_SYS_SELECT_H therefore?

Yes, at the very least.

Noted.

 

 But let's delay this until you have gone all
the way to building Emacs using this method.  We won't know all of the
implications until you do.

Sure, OK.

I am closing this bug; since you diagnosed my other patch submission as a more general bug in configuration, I'll look into a fix for it at that level.

--
http://rrt.sc3d.org

--- End Message ---