[debbugs-tracker] bug#18551: closed (regression: erc-format-nick is now essentially an alias to address@hidden)

[GNU bug Tracking System]

Your message dated Fri, 21 Nov 2014 19:31:21 +0000
with message-id <address@hidden>
and subject line Re: bug#18551: regression: erc-format-nick is now essentially 
an alias to address@hidden 
has caused the debbugs.gnu.org bug report #18551,
regarding regression: erc-format-nick is now essentially an alias to 
address@hidden
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
18551: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18551
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> regression: erc-format-nick is now essentially an alias to address@hidden 
>
>
>
>
> Date: 
>
> Wed, 24 Sep 2014 21:33:57 +0000
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
>
>
>
>
> Package:  emacs
> X-Debbugs-Cc: Kelvin White <address@hidden>
>
>         The following change (present as of 0ee10aff098b) was introduced
>         into lisp/erc/erc.el back this June:
>
> commit b45734ee82eecb91010eb3055c8c8bafb73a3ade
> Author:     Kelvin White <address@hidden>
> AuthorDate: Thu Jun 19 12:56:18 2014 -0400
>
>     ERC: Better user mode support
>
> --- a/lisp/erc/erc.el
> +++ b/lisp/erc/erc.el
> …
> @@ -4190,7 +4223,24 @@
>  (defun erc-format-nick (&optional user _channel-data)
>    "Return the nickname of USER.
>  See also `erc-format-nick-function'."
> -  (when user (erc-server-user-nickname user)))
> +  (let ((nick (erc-server-user-nickname user)))
> +    (concat (erc-propertize
> +             (erc-get-user-mode-prefix nick)
> +             'face 'erc-nick-prefix-face) nick)))
> …
>
>         This added the “user mode” sign – previously kind of specific to
>         address@hidden – into the string returned by erc-format-nick.
>         Thus, the only code difference left between the two is the
>         (presumably accidental) lack of the (when user …) in the former:
>
>   4227  (defun erc-format-nick (&optional user _channel-data)
> …
>   4230    (let ((nick (erc-server-user-nickname user)))
>   4231      (concat (erc-propertize
>   4232               (erc-get-user-mode-prefix nick)
>   4233               'face 'erc-nick-prefix-face)
>   4234              nick)))
>
>   4250  (defun address@hidden (&optional user channel-data)
> …
>   4256    (when user
>   4257      (let ((nick (erc-server-user-nickname user)))
>   4258        (concat (erc-propertize
>   4259                 (erc-get-user-mode-prefix nick)
>   4260                 'face 'erc-nick-prefix-face)
>   4261                nick))))
>
>         I believe that this change was unintended, is not helpful in any
>         way (if the intent was to get rid of the former, it should’ve
>         been aliased over, not redefined, shouldn’t it?), and should
>         thus be reverted.
>
> -- 
> FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A
>
> --- a/lisp/erc/erc.el
> +++ b/lisp/erc/erc.el
> @@ -4227,11 +4227,7 @@
>  (defun erc-format-nick (&optional user _channel-data)
>    "Return the nickname of USER.
>  See also `erc-format-nick-function'."
> -  (let ((nick (erc-server-user-nickname user)))
> -    (concat (erc-propertize
> -             (erc-get-user-mode-prefix nick)
> -             'face 'erc-nick-prefix-face)
> -           nick)))
> +  (when user (erc-server-user-nickname user)))
>  
>  (defun erc-get-user-mode-prefix (user)
>    (when user
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#18551: regression: erc-format-nick is now essentially an alias to address@hidden 
>
>
>
>
> Date: 
>
> Fri, 21 Nov 2014 19:31:21 +0000
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
>
>
>
>
> Version: 25.1
>
>         I no longer observe the issue (as of 2014-11-18 build,
>         cb4f666ade76.)  Per my reading of the Git log, it was fixed in
>         Git master back this September:
>
> Author:     Kelvin White <address@hidden>
> AuthorDate: Fri Sep 26 09:22:47 2014 -0400
> Commit:     Kelvin White <address@hidden>
> CommitDate: Fri Sep 26 09:22:47 2014 -0400
>
>     Regression fix - #bug18551
>
>         As it seems, the emacs-24 branch was never affected by this bug.
>
> -- 
> FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A
>
>
> --- End Message ---