[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#19566: closed ((unload-feature 'misearch) breaks i

From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#19566: closed ((unload-feature 'misearch) breaks isearch )
Date: Fri, 23 Jan 2015 14:27:02 +0000

Your message dated Fri, 23 Jan 2015 14:25:55 +0000
with message-id <address@hidden>
and subject line Re: bug#19566: unloading support for misearch 
has caused the debbugs.gnu.org bug report #19566,
regarding (unload-feature 'misearch) breaks isearch 
to be marked as done.

(If you believe you have received this mail in error, please contact

19566: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19566
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: (unload-feature 'misearch) breaks isearch Date: Sun, 11 Jan 2015 11:37:57 +0000 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
Package:  emacs
Severity: minor
Tags: patch

        Using unload-feature to unload misearch.el also undefines the
        autoloaded variables, which breaks isearch.el as it still uses

        Please thus consider the patch MIMEd.

        * lisp/misearch.el (multi-isearch-unload-function): New function
        to retain definitions of autoloaded variables when unloading.
        (misearch-unload-function): New alias.

FSF associate member #7257  np. The Middle Path — David Modica B6A0 230E 334A
--- a/lisp/misearch.el
+++ b/lisp/misearch.el
@@ -377,6 +377,25 @@
     (goto-char (if isearch-forward (point-min) (point-max)))
     (isearch-forward-regexp nil t)))
+(defun multi-isearch-unload-function ()
+  "Remove autoloaded variables from `unload-function-defs-list'.
+Also prevent the feature from being reloaded via `isearch-mode-hook'."
+  (remove-hook 'isearch-mode-hook 'multi-isearch-setup)
+  (let ((defs (list (car unload-function-defs-list)))
+       (auto '(multi-isearch-next-buffer-function
+               multi-isearch-next-buffer-current-function
+               multi-isearch-current-buffer
+               multi-isearch-buffer-list multi-isearch-file-list)))
+    (dolist (def (cdr unload-function-defs-list))
+      (unless (and (symbolp def)
+                  (memq def auto))
+       (push def defs)))
+    (setq unload-function-defs-list (nreverse defs))
+    ;; .
+    nil))
+(defalias 'misearch-unload-function 'multi-isearch-unload-function)
 (provide 'multi-isearch)
 (provide 'misearch)

--- End Message ---
--- Begin Message --- Subject: Re: bug#19566: unloading support for misearch Date: Fri, 23 Jan 2015 14:25:55 +0000 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
Version: 25.1

        I’ve pushed the change proposed to ‘master’ last Saturday;

commit 0aaa5d699bf95afb152317f0788b8e2d2042f59d
CommitDate: Sat Jan 17 19:35:52 2015 +0000

    Unloading support for misearch.

    * lisp/misearch.el (multi-isearch-unload-function): New function.
    (misearch-unload-function): New alias.

    Fixes: debbugs:19566

FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]