emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#17945: closed (24.4.50; vc-git-annotate-command is


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#17945: closed (24.4.50; vc-git-annotate-command is too slow)
Date: Thu, 26 Feb 2015 14:57:02 +0000

Your message dated Thu, 26 Feb 2015 15:56:05 +0100
with message-id <address@hidden>
and subject line Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow
has caused the debbugs.gnu.org bug report #17945,
regarding 24.4.50; vc-git-annotate-command is too slow
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
17945: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17945
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 24.4.50; vc-git-annotate-command is too slow Date: Sat, 5 Jul 2014 20:28:37 +0800
C-x v g on a git file is very slow, compare this:

    $ time git --no-pager  blame  -- vc-annotate.el 1>/dev/null

    real    0m1.432s
    user    0m1.364s
    sys    0m0.063s


    $ time git --no-pager  blame -C -C  -- vc-annotate.el 1>/dev/null

    real    0m23.477s
    user    0m22.058s
    sys    0m1.405s

It seems the -C -C options would slow down git hugely, making this
command almost useless.  Can we remove it from default option list?

-William

git version 1.9.3

In GNU Emacs 24.4.50.1 (i386-apple-darwin13.1.0, NS apple-appkit-1265.19)
 of 2014-04-16 on tokyolove.local
Windowing system distributor `Apple', version 10.3.1265
Configured using:
 `configure --with-ns CC=clang'

Configured features:
ACL GNUTLS LIBXML2 ZLIB

Important settings:
  locale-coding-system: utf-8-unix


--- End Message ---
--- Begin Message --- Subject: Re: bug#17945: 24.4.50; vc-git-annotate-command is too slow Date: Thu, 26 Feb 2015 15:56:05 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)
Glenn Morris <address@hidden> writes:

> Óscar Fuentes wrote:
>
>> So what about this patch?
>
> Looks, right, except vc-annotate-switches does not exist and would also
> need to be added. And for consistency, presumably all backends should
> get the same treatment. Thanks.

Implemented on b5a0603eb41c7a350c16a1b3ec5c1b8d8c84a4eb.

I'm neutral about the existence of vc-annotate-switches, so if anyone
wants to remove it (including mentions on the docstrings of
vc-BACKEND-annotate-switches) it's fine with me.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]