[debbugs-tracker] bug#20156: closed (Emacs 24 stack corruption in fontset.c:fontset_pattern_regexp)

[GNU bug Tracking System]

Your message dated Sun, 22 Mar 2015 10:23:27 +0100
with message-id <address@hidden>
and subject line Re: bug#20156: Emacs 24 stack corruption in 
fontset.c:fontset_pattern_regexp
has caused the debbugs.gnu.org bug report #20156,
regarding Emacs 24 stack corruption in fontset.c:fontset_pattern_regexp
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
20156: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20156
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Emacs 24 stack corruption in fontset.c:fontset_pattern_regexp Date: Sat, 21 Mar 2015 12:06:16 +0000

Emacs crashes on Mac Yosemite (native window system) when I use set-frame-font 
with certain font patterns.  The cause is writing past the end of an alloca 
buffer in fontset.c:fontset_pattern_regexp.  This triggers a stack check 
assertion.  Alloca is used to allocate space for a regexp, but the size 
neglects to consider the ^$ around the regexp.  “+1” should be “+3”.

To reproduce:

(set-frame-font "-adobe-courier-medium-r-normal--24-*-75-75-m-150-iso8859-1”)

without X installed.

Bug in 24.3 and "GNU Emacs 24.4.2 (x86_64-apple-darwin14.1.0, NS 
apple-appkit-1344.72)”.

fontset.diff
Description: fontset.diff

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#20156: Emacs 24 stack corruption in fontset.c:fontset_pattern_regexp
>
>
>
>
> Date: 
>
> Sun, 22 Mar 2015 10:23:27 +0100
>
>
>
>
> Good call.  Fixed in trunk and emacs-24 branch.
>
>         Jan D.
>
> > 21 mar 2015 kl. 13:06 skrev John F Carr <address@hidden>:
> > 
> > Emacs crashes on Mac Yosemite (native window system) when I use 
> > set-frame-font with certain font patterns.  The cause is writing past the end 
> > of an alloca buffer in fontset.c:fontset_pattern_regexp.  This triggers a 
> > stack check assertion.  Alloca is used to allocate space for a regexp, but 
> > the size neglects to consider the ^$ around the regexp.  “+1” should be “+3”.
> > 
> > To reproduce:
> > 
> > (set-frame-font "-adobe-courier-medium-r-normal--24-*-75-75-m-150-iso8859-1”)
> > 
> > without X installed.
> > 
> > Bug in 24.3 and "GNU Emacs 24.4.2 (x86_64-apple-darwin14.1.0, NS 
> > apple-appkit-1344.72)”.
> > 
> > 
> > 
> > <fontset.diff>
>
>
>
> --- End Message ---