[debbugs-tracker] bug#20536: closed (avoid new gcc warning: ENOTSUP vs EOPNOTSUPP)

[GNU bug Tracking System]

Your message dated Sat, 09 May 2015 23:19:41 +0100
with message-id <address@hidden>
and subject line Re: bug#20536: avoid new gcc warning: ENOTSUP vs EOPNOTSUPP
has caused the debbugs.gnu.org bug report #20536,
regarding avoid new gcc warning: ENOTSUP vs EOPNOTSUPP
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
20536: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20536
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: avoid new gcc warning: ENOTSUP vs EOPNOTSUPP Date: Sat, 9 May 2015 11:15:07 -0700

Building with very new gcc-from-git, I encountered 3 new warnings.
Here's a patch to address them:

Without this change, very recent gcc (e.g., version 6.0.0 20150509)
would print the following when configured with --enable-gcc-warnings:

  src/copy.c:165:30: error: logical 'or' of equal expressions \
    [-Werror=logical-op]
    && (errno == EOPNOTSUPP || errno == ENOTSUP || errno == ENOSYS))
                           ^
* src/system.h (is_ENOTSUP): New function.
* src/copy.c (punch_hole): Use it.
* src/ls.c (errno_unsupported, gobble_file): Use it.

0001-build-avoid-a-warning-form-gcc-s-new-Wlogical-op.patch
Description: Binary data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#20536: avoid new gcc warning: ENOTSUP vs EOPNOTSUPP
>
>
>
>
> Date: 
>
> Sat, 09 May 2015 23:19:41 +0100
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
>
>
>
>
> On 09/05/15 19:15, Jim Meyering wrote:
> > Building with very new gcc-from-git, I encountered 3 new warnings.
> > Here's a patch to address them:
> > 
> > Without this change, very recent gcc (e.g., version 6.0.0 20150509)
> > would print the following when configured with --enable-gcc-warnings:
> > 
> >   src/copy.c:165:30: error: logical 'or' of equal expressions \
> >     [-Werror=logical-op]
> >     && (errno == EOPNOTSUPP || errno == ENOTSUP || errno == ENOSYS))
> >                            ^
> > * src/system.h (is_ENOTSUP): New function.
> > * src/copy.c (punch_hole): Use it.
> > * src/ls.c (errno_unsupported, gobble_file): Use it.
>
> Not sure I agree with GCC's warning here,
> but the fix looks good.
>
> Marking this as done.
>
> thanks!
> Pádraig
>
>
> --- End Message ---