[debbugs-tracker] bug#20925: closed (25.0.50; isearch-exit calls isearch-done twice)

[GNU bug Tracking System]

Your message dated Tue, 30 Jun 2015 08:13:50 +0900
with message-id <address@hidden>
and subject line Re: bug#20925: 25.0.50; isearch-exit calls isearch-done twice
has caused the debbugs.gnu.org bug report #20925,
regarding 25.0.50; isearch-exit calls isearch-done twice
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
20925: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20925
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 25.0.50; isearch-exit calls isearch-done twice
>
>
>
>
> Date: 
>
> Mon, 29 Jun 2015 18:27:18 +0900
>
>
>
>
> User-agent: 
>
> Gnus/5.130014 (真 Gnus v0.14) Emacs/25.0.50 (i686-pc-cygwin)
>
>
>
>
> Recipe: C-s [RET] foo [RET]
>
> Debugger entered--Lisp error: (wrong-type-argument stringp nil)
>   set-buffer(nil)
>   (with-current-buffer isearch--current-buffer ...)
>   isearch-done()
>   isearch-exit() ;; this calls `isearch-done'
>   funcall-interactively(isearch-exit)
>   call-interactively(isearch-exit nil nil)
>   command-execute(isearch-exit)
>
> `isearch-exit' calls `isearch-done' by way of `isearch-edit-string'
> and `with-isearch-suspended', and then calls it again.
> I don't know why it does so but this change gets rid of the error:
>
> --- isearch.el~ 2015-06-28 22:04:38.000000000 +0000
> +++ isearch.el  2015-06-29 09:26:19.216444200 +0000
> @@ -1184,8 +1184,8 @@
>    (if (and search-nonincremental-instead
>            (= 0 (length isearch-string)))
>        (let ((isearch-nonincremental t))
> -       (isearch-edit-string)))
> -  (isearch-done)
> +       (isearch-edit-string))
> +    (isearch-done))
>    (isearch-clean-overlays))
>  
>  (defun isearch-fail-pos (&optional msg)
>
> Thanks.
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#20925: 25.0.50; isearch-exit calls isearch-done twice
>
>
>
>
> Date: 
>
> Tue, 30 Jun 2015 08:13:50 +0900
>
>
>
>
> User-agent: 
>
> Gnus/5.130014 (真 Gnus v0.14) Emacs/25.0.50 (i686-pc-cygwin)
>
>
>
>
> On Tue, 30 Jun 2015 01:07:08 +0300, Juri Linkov <address@hidden> wrote:
> > Thanks, I believe this is the right fix to avoid calling
> > ‘isearch-done’ twice.  Could you please add a short 1-line comment
> > explaining that ‘isearch-edit-string’ already calls ‘isearch-done’.
>
> Thanks.  Committed.
> I'm sorry I was unable to explain it in a short 1-line comment,
> but I divided it into an inline comment and a log entry. :)
>
>
> --- End Message ---